Skip to content

[fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer #25596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merlimat merged 1 commit into from
Apr 28, 2026
Merged

[fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer #25596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...t/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,10 +1376,15 @@ public void testLoadBalancerServiceUnitTableViewSyncer() throws Exception {
assertTrue(pulsar2.getConfiguration().isLoadBalancerServiceUnitTableViewSyncerEnabled()));
makeSecondaryAsLeader();
makePrimaryAsLeader();
Awaitility.await().atMost(30, TimeUnit.SECONDS)
// playLeader()/playFollower() run on a single-threaded loadManagerExecutor, so
// playLeader() on the new leader can be queued behind a still-running playFollower()
// from the prior demotion. Under CI load this serial chain plus the syncer.start()
// work (which opens both table views and runs syncExistingItems/syncTailItems)
// can take longer than 30s, so use a more generous timeout here.
Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertTrue(primaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
Awaitility.await().atMost(30, TimeUnit.SECONDS)
Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertFalse(secondaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
ServiceConfiguration defaultConf = getDefaultConf();
Expand Down Expand Up @@ -1590,10 +1595,10 @@ public void testLoadBalancerServiceUnitTableViewSyncer() throws Exception {
Awaitility.await().untilAsserted(() ->
assertFalse(pulsar2.getConfiguration().isLoadBalancerServiceUnitTableViewSyncerEnabled()));
makeSecondaryAsLeader();
Awaitility.await().atMost(30, TimeUnit.SECONDS)
Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertFalse(primaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
Awaitility.await().atMost(30, TimeUnit.SECONDS)
Awaitility.await().atMost(60, TimeUnit.SECONDS)
.untilAsserted(() -> assertFalse(secondaryLoadManager.getServiceUnitStateTableViewSyncer()
.isActive()));
}
Expand Down
Loading