Support set message TTL on topic level. - #7738
Merged
Merged
Conversation
Add support for message TTL at Topic level using System Topic backed Topic policy.
sijie
requested review from
codelipenghui,
jiazhai,
merlimat,
rdhabalia and
sijie
and removed request for
codelipenghui
August 4, 2020 04:42
sijie
added
component/topic-policy
type/feature
Contributor
Author
|
/pulsarbot run-failure-checks |
Improve test stability by trigger namespace bundle load to make sure topic initialized when test case is ran Similar to what we do for TopicBacklogQuotaTest. Also added wait time after setup.
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
jianyun8023
reviewed
Aug 5, 2020
jianyun8023
left a comment
jianyun8023
left a comment
Contributor
There was a problem hiding this comment.
You did it very well.👍
|
|
||
| @DELETE | ||
| @Path("/{tenant}/{namespace}/{topic}/messageTTL") | ||
| @ApiOperation(value = "Set message TTL in seconds for a topic") |
Contributor
There was a problem hiding this comment.
Remove message TTL in seconds for a topic
codelipenghui
added
the
doc-required
codelipenghui
approved these changes
Aug 5, 2020
codelipenghui
left a comment
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, please fix the comment that @jianyun8023 mentioned
Contributor
Author
|
/pulsarbot run-failure-checks |
13 tasks
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation Master Issue: apache#2688 Add Topic level policy support for message TTL. ### Modifications Support set/get/remove Message TTL on topic level. ### Verifying this change This change added tests and can be verified as follows: - *Added Unit test to verify set/get/remove message TTL at Topic level work as expected when Topic level policy is enabled/disabled* - *Added test case in PersistentTopicE2ETest to verify Topic level message TTL is used when set and will fall back to namespace message TTL if Topic level message TTL is removed.*
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Master Issue: apache#2688 Add Topic level policy support for message TTL. ### Modifications Support set/get/remove Message TTL on topic level. ### Verifying this change This change added tests and can be verified as follows: - *Added Unit test to verify set/get/remove message TTL at Topic level work as expected when Topic level policy is enabled/disabled* - *Added test case in PersistentTopicE2ETest to verify Topic level message TTL is used when set and will fall back to namespace message TTL if Topic level message TTL is removed.*
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Master Issue: apache#2688 Add Topic level policy support for message TTL. ### Modifications Support set/get/remove Message TTL on topic level. ### Verifying this change This change added tests and can be verified as follows: - *Added Unit test to verify set/get/remove message TTL at Topic level work as expected when Topic level policy is enabled/disabled* - *Added test case in PersistentTopicE2ETest to verify Topic level message TTL is used when set and will fall back to namespace message TTL if Topic level message TTL is removed.*
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Master Issue: apache#2688 Add Topic level policy support for message TTL. ### Modifications Support set/get/remove Message TTL on topic level. ### Verifying this change This change added tests and can be verified as follows: - *Added Unit test to verify set/get/remove message TTL at Topic level work as expected when Topic level policy is enabled/disabled* - *Added test case in PersistentTopicE2ETest to verify Topic level message TTL is used when set and will fall back to namespace message TTL if Topic level message TTL is removed.*
jiazhai
pushed a commit
that referenced
this pull request
Sep 15, 2020
…stence polices, message TTL, and backlog quota on topic level (#7852) Motivation In PRs, #7738, #7646, #7817, persistence polices, message TTL, and backlog quota policies are supported on topic level. The PR for code modification is updated and merged. but the doc is not updated accordingly. This PR is used to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. Modifications Update the Pulsar Admin CLI doc to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. * Update backlog-quota policies on topic level * update contents * update contents
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
…stence polices, message TTL, and backlog quota on topic level (apache#7852) Motivation In PRs, apache#7738, apache#7646, apache#7817, persistence polices, message TTL, and backlog quota policies are supported on topic level. The PR for code modification is updated and merged. but the doc is not updated accordingly. This PR is used to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. Modifications Update the Pulsar Admin CLI doc to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. * Update backlog-quota policies on topic level * update contents * update contents
|
Hi team, do we have any plan to publish official document on this feature? |
Anonymitaet
added
doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Master Issue: #2688
Add Topic level policy support for message TTL.
Modifications
Support set/get/remove Message TTL on topic level.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation