[ISSUE 7757] Support Persistence Policies on topic level - #7817
Merged
codelipenghui merged 4 commits intoAug 17, 2020
Conversation
…s-on-topic-level # Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
|
@jianyun8023 Please help review this PR. |
jianyun8023
reviewed
Aug 14, 2020
jianyun8023
left a comment
jianyun8023
left a comment
Contributor
There was a problem hiding this comment.
left some minor comments.
Comment on lines
+2298
to
+2311
| protected void internalGetPersistence(AsyncResponse asyncResponse){ | ||
| validateAdminAccessForTenant(namespaceName.getTenant()); | ||
| validatePoliciesReadOnlyAccess(); | ||
| if (topicName.isGlobal()) { | ||
| validateGlobalNamespaceOwnership(namespaceName); | ||
| } | ||
| Optional<PersistencePolicies> retention = getTopicPolicies(topicName) | ||
| .map(TopicPolicies::getPersistence); | ||
| if (!retention.isPresent()) { | ||
| asyncResponse.resume(Response.noContent().build()); | ||
| }else { | ||
| asyncResponse.resume(retention.get()); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
minor: there is no need to use asyncResponse
Contributor
Author
There was a problem hiding this comment.
It is same to internalGetRetention(), maybe we can modify it all at once.
codelipenghui
requested changes
Aug 14, 2020
codelipenghui
left a comment
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
The change looks do not handle the topic creation according to the topic policy if the topic level persistent policy exists. You can refer to createPersistentTopic method in the BrokerService.java
Contributor
Author
Done. |
Contributor
Author
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Aug 15, 2020
codelipenghui
approved these changes
Aug 17, 2020
codelipenghui
added
the
doc-required
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Link [https://github.com/apache/pulsar/issues/7757](https://github.com/apache/pulsar/issues/7757) and master issue [https://github.com/apache/pulsar/issues/2688](https://github.com/apache/pulsar/issues/2688) ### Motivation Support set/get/remove persistence policies on topic level. ### Verifying this change new unit test added.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Link [https://github.com/apache/pulsar/issues/7757](https://github.com/apache/pulsar/issues/7757) and master issue [https://github.com/apache/pulsar/issues/2688](https://github.com/apache/pulsar/issues/2688) ### Motivation Support set/get/remove persistence policies on topic level. ### Verifying this change new unit test added.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Link [https://github.com/apache/pulsar/issues/7757](https://github.com/apache/pulsar/issues/7757) and master issue [https://github.com/apache/pulsar/issues/2688](https://github.com/apache/pulsar/issues/2688) ### Motivation Support set/get/remove persistence policies on topic level. ### Verifying this change new unit test added.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Link [https://github.com/apache/pulsar/issues/7757](https://github.com/apache/pulsar/issues/7757) and master issue [https://github.com/apache/pulsar/issues/2688](https://github.com/apache/pulsar/issues/2688) ### Motivation Support set/get/remove persistence policies on topic level. ### Verifying this change new unit test added.
jiazhai
pushed a commit
that referenced
this pull request
Sep 15, 2020
…stence polices, message TTL, and backlog quota on topic level (#7852) Motivation In PRs, #7738, #7646, #7817, persistence polices, message TTL, and backlog quota policies are supported on topic level. The PR for code modification is updated and merged. but the doc is not updated accordingly. This PR is used to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. Modifications Update the Pulsar Admin CLI doc to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. * Update backlog-quota policies on topic level * update contents * update contents
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Oct 3, 2020
…stence polices, message TTL, and backlog quota on topic level (apache#7852) Motivation In PRs, apache#7738, apache#7646, apache#7817, persistence polices, message TTL, and backlog quota policies are supported on topic level. The PR for code modification is updated and merged. but the doc is not updated accordingly. This PR is used to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. Modifications Update the Pulsar Admin CLI doc to support to set/get/remove persistence polices, message TTL, and backlog quota on topic level. * Update backlog-quota policies on topic level * update contents * update contents
Anonymitaet
added
doc
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link #7757 and master issue #2688
Motivation
Support set/get/remove persistence policies on topic level.
Verifying this change
new unit test added.