Skip to content

Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility - #8361

Closed
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-fix-protoc-gen-grpc-java-version
Closed

Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility#8361
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-fix-protoc-gen-grpc-java-version

Conversation

@lhotari

@lhotari lhotari commented Oct 23, 2020

Copy link
Copy Markdown
Member
  • CI fails currently because of grpc version incompatibilities

Another PR job failed with this kind of exception:

13:11:31.285 [main] ERROR org.apache.bookkeeper.common.component.AbstractLifecycleComponent - Failed to start Component: storage-service
java.lang.NoSuchMethodError: io.grpc.internal.DnsNameResolverProvider.newNameResolver(Ljava/net/URI;Lio/grpc/Attributes;)Lio/grpc/internal/DnsNameResolver;
	at org.apache.bookkeeper.common.resolver.ServiceNameResolverProvider.newNameResolver(ServiceNameResolverProvider.java:95) ~[org.apache.bookkeeper-stream-storage-java-client-4.10.0.jar:4.10.0]
	at org.apache.bookkeeper.common.resolver.NameResolverProviderFactory.newNameResolver(NameResolverProviderFactory.java:45) ~[org.apache.bookkeeper-stream-storage-java-client-4.10.0.jar:4.10.0]
	at io.grpc.NameResolver$Factory.newNameResolver(NameResolver.java:207) ~[io.grpc-grpc-api-1.31.0.jar:1.31.0]
	at io.grpc.NameResolver$Factory.newNameResolver(NameResolver.java:235) ~[io.grpc-grpc-api-1.31.0.jar:1.31.0]
	at io.grpc.internal.ManagedChannelImpl.getNameResolver(ManagedChannelImpl.java:701) ~[io.grpc-grpc-core-1.31.0.jar:1.31.0]
	at io.grpc.internal.ManagedChannelImpl.<init>(ManagedChannelImpl.java:606) ~[io.grpc-grpc-core-1.31.0.jar:1.31.0]

in https://github.com/apache/pulsar/runs/1297863577?check_suite_focus=true

I'd assume that protoc-gen-grpc-java.version should match grpc.version . I also added a change in the PR to use the grpc-bom in dependencyManagement.

- CI fails currently because of grpc version incompatibilities
@lhotari lhotari changed the title Use grpc-bom and protoc-gen-grpc-java version match grpc.version Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility Oct 23, 2020
@lhotari

lhotari commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

@pkumar-singh and @merlimat , please review these changes since they are related to the recent change #8351 . Thank you

@lhotari

lhotari commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

I found this issue grpc/grpc-java#5556 and I would assume that upgrading protoc-gen-grpc-java.version fixes the problem. I just wonder why the checks passed in #8351 and this issue didn't show up earlier.

@lhotari

lhotari commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

There's a bug in the Github flow. It considers a pom.xml change a documentation only change. I filed #8362.

@lhotari

lhotari commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

There seems to be some remaining issues, I cherry picked this to another PR and it still fails. Perhaps it's better to revert the grpc upgrade until the issue is completely resolved.

@lhotari

lhotari commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

I'm running an experiment in #8358 to see if reverting 647d3c2 fixes the issues.

@lhotari

lhotari commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

I opened #8363 to revert the grpc upgrade since master branch is currently broken. I'll close this PR because of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant