Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility - #8361
Closed
lhotari wants to merge 1 commit into
Closed
Conversation
- CI fails currently because of grpc version incompatibilities
Member
Author
|
@pkumar-singh and @merlimat , please review these changes since they are related to the recent change #8351 . Thank you |
Member
Author
|
I found this issue grpc/grpc-java#5556 and I would assume that upgrading protoc-gen-grpc-java.version fixes the problem. I just wonder why the checks passed in #8351 and this issue didn't show up earlier. |
Member
Author
|
There's a bug in the Github flow. It considers a pom.xml change a documentation only change. I filed #8362. |
This was referenced Oct 23, 2020
Member
Author
|
There seems to be some remaining issues, I cherry picked this to another PR and it still fails. Perhaps it's better to revert the grpc upgrade until the issue is completely resolved. |
Member
Author
Member
Author
|
I opened #8363 to revert the grpc upgrade since master branch is currently broken. I'll close this PR because of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR job failed with this kind of exception:
in https://github.com/apache/pulsar/runs/1297863577?check_suite_focus=true
I'd assume that protoc-gen-grpc-java.version should match grpc.version . I also added a change in the PR to use the grpc-bom in dependencyManagement.