Revert "PLSR-1240 upgrade GRPC to 1.31 to avoid deadlock" - #8363
Merged
Conversation
- there are grpc/protobuf version compatibility issues - tests weren't run because of apache#8362 This reverts commit 647d3c2.
Member
Author
|
There were this kind of errors in PR #8358 builds in https://github.com/apache/pulsar/runs/1297863577?check_suite_focus=true I was assuming that protoc-gen-grpc-java.version should match grpc.version. However this led to some other issues. |
This was referenced Oct 23, 2020
pkumar-singh
approved these changes
Oct 23, 2020
sijie
approved these changes
Oct 23, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
- there are grpc/protobuf version compatibility issues - tests weren't run because of apache#8362 This reverts commit 647d3c2.
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
- there are grpc/protobuf version compatibility issues - tests weren't run because of apache#8362 This reverts commit 647d3c2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8351
there are grpc/protobuf version compatibility issues and the master branch is currently broken
tests weren't run when merging Upgrade GRPC to 1.31 to avoid deadlock #8351 because of [Github Flow] pom.xml change is considered a documentation change #8362
This reverts commit 647d3c2.