Support key based batch builder for Go Functions - #8761
Merged
wolfstudy merged 7 commits intoDec 3, 2020
Conversation
Signed-off-by: xiaolong.ran <rxl@apache.org>
wolfstudy
requested review from
codelipenghui,
jerrypeng,
jiazhai,
merlimat and
sijie
December 1, 2020 09:21
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
Could you please a unit test for this change?
Member
Author
In fact, in the integration test, we already test this case. In And in create different language functions, we will use |
codelipenghui
approved these changes
Dec 2, 2020
Member
Author
|
RobertIndie
pushed a commit
to RobertIndie/pulsar
that referenced
this pull request
Dec 8, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org> ### Motivation The changing base on apache#8523 ### Modifications Support key_based batch builder for Go Functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran rxl@apache.org
Motivation
The changing base on #8523
Modifications
Support key_based batch builder for Go Functions