Issue #9123 Go Functions - #9124
Conversation
|
@flowchartsman Can you rebase to the latest master to include recent changes that fix the broken master? |
|
@freeznet Can you review this change? |
|
@flowchartsman @sijie I have some findings related to #8761. Currently go functions get |
|
@freeznet, it seems like what you're saying is that my fix is a band-aid at a lower level, and that the other changes would fix this the right way, is that correct? If so, I think I should close this PR and we should make a new one that correctly fixes all of the issues you mention. |
|
@flowchartsman I think this PR is great and LGTM since it add nil check for pointer, and the nil check is always welcome. But as you said, we should work on another PR to make BatchBuilder exposed to user properly. |
84bc333 to
b78807e
Compare
|
@sijie should be rebased now, I believe |
|
@flowchartsman Thank you! |
|
/pulsarbot run-failure-checks |
Fixes apache#9123 Check for nil ProducerSpec first as in apache#9123 (cherry picked from commit 3b6fa26)
This reverts commit 3b6fa26.
### Motivation Currently, the docker is from `openjdk:8-jdk-slim `, it has a new release a few days ago and the Linux version was changed to `Impish`, it didn't support install `python3.7` by apt-get tool, the minimum Python version is 3.9, so we need to change the python version or use a different Linux release, I cherry-pick some commits from branch master to build docker image from the `ubuntu:20.04`. Mainly related PRs: 1. #11026 2. #11623 3. #11862 ### Modifications Build docker image from the `ubuntu:20.04`. upgrade pulsar-go-client from `0.2.0` to `0.6.0` and rever #9124 from branch-2.7
Currently, the docker is from `openjdk:8-jdk-slim `, it has a new release a few days ago and the Linux version was changed to `Impish`, it didn't support install `python3.7` by apt-get tool, the minimum Python version is 3.9, so we need to change the python version or use a different Linux release, I cherry-pick some commits from branch master to build docker image from the `ubuntu:20.04`. Mainly related PRs: 1. apache#11026 2. apache#11623 3. apache#11862 Build docker image from the `ubuntu:20.04`. upgrade pulsar-go-client from `0.2.0` to `0.6.0` and rever apache#9124 from branch-2.7 (cherry picked from commit 259c698)
Currently, the docker is from `openjdk:8-jdk-slim `, it has a new release a few days ago and the Linux version was changed to `Impish`, it didn't support install `python3.7` by apt-get tool, the minimum Python version is 3.9, so we need to change the python version or use a different Linux release, I cherry-pick some commits from branch master to build docker image from the `ubuntu:20.04`. Mainly related PRs: 1. apache#11026 2. apache#11623 3. apache#11862 Build docker image from the `ubuntu:20.04`. upgrade pulsar-go-client from `0.2.0` to `0.6.0` and rever apache#9124 from branch-2.7 (cherry picked from commit 259c698)
4 participants
Fixes #9123
Modifications
Check for nil ProducerSpec first
Verifying this change
as in #9123