[pulsar-broker] cluster resources use metadata-store api - #9338
Merged
Conversation
fix tests fix intermittent test failure
aahmed-se
approved these changes
Jan 27, 2021
Contributor
Author
|
/pulsarbot run-failure-checks |
rdhabalia
force-pushed
the
zk_rest_cluster
branch
from
January 28, 2021 04:22
20b69de to
57449ed
Compare
jiazhai
pushed a commit
to streamnative/kop
that referenced
this pull request
Feb 26, 2021
This version update is convenient for tests in real environment since there's no binary download url for original pulsar `2.8.0-rc-202101252233`. This PR fixes the API incompatibility problems that are introduced by apache/pulsar#9397 and apache/pulsar#9302. Another significant change between these two versions is apache/pulsar#9338, which introduced metadata-store API for cluster resources. This PR fixed the test failure caused by it as well. Since KoP `tests` module only uses one `MockZooKeeper` to manage z-nodes, see `KopProtocolHandlerTestBase#createMockZooKeeper`, the mocked `createConfigurationMetadataStore` method returns `mockedZooKeeper` here instead of a `mockedZooKeeperGlobal` like what Pulsar did in `MockedPulsarServiceBaseTest`. Besides, there's a test bug in `testBrokerHandleTopicMetadataRequest` that was not exposed by the previous Pulsar. This PR fixes it.
merlimat
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Apr 6, 2021
* [pulsar-broker] Make tenant rest-api async and use metadata-store api fix tests fix intermittent test failure * [pulsar-broker] cluster resources use metadata-store api * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is on top of #9270, with this change, cluster-resources will start using metadata-api and remove zk-dependency.