This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Bump pulsar to 2.8.0-rc-202102252222 - #386
Merged
jiazhai merged 2 commits intoFeb 26, 2021
Merged
Conversation
BewareMyPower
changed the title
Contributor
Author
|
Some deleted classes should be recovered first. |
Contributor
Author
|
It looks like Pulsar introduced some changes that make integration tests fail. I'll figure out the reason. |
BewareMyPower
force-pushed
the
bewaremypower/bump-pulsar-2.8.0-rc-202102252222
branch
from
February 26, 2021 08:43
6d2469e to
649be78
Compare
BewareMyPower
force-pushed
the
bewaremypower/bump-pulsar-2.8.0-rc-202102252222
branch
from
February 26, 2021 08:55
649be78 to
f46a225
Compare
BewareMyPower
changed the title
jiazhai
approved these changes
Feb 26, 2021
BewareMyPower
deleted the
bewaremypower/bump-pulsar-2.8.0-rc-202102252222
branch
February 26, 2021 10:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version update is convenient for tests in real environment since there's no binary download url for original pulsar
2.8.0-rc-202101252233.This PR fixes the API incompatibility problems that are introduced by apache/pulsar#9397 and apache/pulsar#9302.
Another significant change between these two versions is apache/pulsar#9338, which introduced metadata-store API for cluster resources. This PR fixed the test failure caused by it as well. Since KoP
testsmodule only uses oneMockZooKeeperto manage z-nodes, seeKopProtocolHandlerTestBase#createMockZooKeeper, the mockedcreateConfigurationMetadataStoremethod returnsmockedZooKeeperhere instead of amockedZooKeeperGloballike what Pulsar did inMockedPulsarServiceBaseTest.Besides, there's a test bug in
testBrokerHandleTopicMetadataRequestthat was not exposed by the previous Pulsar. This PR fixes it.