[ISSUE #380] Fix message track showing NOT_CONSUME_YET for consumed messages#10595
Closed
itxaiohanglover wants to merge 2 commits into
Closed
[ISSUE #380] Fix message track showing NOT_CONSUME_YET for consumed messages#10595itxaiohanglover wants to merge 2 commits into
itxaiohanglover wants to merge 2 commits into
Conversation
…umed messages In DefaultMQAdminExtImpl.consumed() and consumedConcurrent(), the consumer offset comparison used strict greater-than (>) instead of greater-than-or-equal (>=). When the consumer offset exactly matched the message's queue offset, the message was incorrectly reported as NOT_CONSUME_YET instead of CONSUMED. This affected the dashboard's message track view, where messages that were just consumed would still show as "NOT_CONSUME_YET".
yx9o
requested changes
Jul 6, 2026
yx9o
left a comment
yx9o
left a comment
Contributor
There was a problem hiding this comment.
I don't think this change is correct. consumerOffset means the next offset to consume, so the current > check is expected.
Author
|
Thank you for the review @yx9o. You're right — Closing this PR as the fix is incorrect. I'll re-investigate the root cause of the dashboard issue #380 to find the actual source of the false NOT_CONSUME_YET status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes apache/rocketmq-dashboard#380
In
DefaultMQAdminExtImpl.consumed()andconsumedConcurrent(), the consumer offset comparison used strict>instead of>=. When the consumer offset exactly matched the message's queue offset, the message was incorrectly reported asNOT_CONSUME_YETinstead ofCONSUMED.Brief changelog
>to>=inconsumed()method>to>=inconsumedConcurrent()methodtestConsumedWithEqualOffsetverifying the fixVerifying this change
Added test case
testConsumedWithEqualOffsetthat sets consumerOffset equal to the message's queueOffset and verifiesconsumed()returns true.