[ISSUE #379] FIX admin subcommand consumeMessage can pull message with timestamp greater than now#380
Merged
vongosling merged 1 commit intoJul 23, 2018
Conversation
renshuaibing-aaron
pushed a commit
to renshuaibing-aaron/rocketmq
that referenced
this pull request
Apr 13, 2020
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
This was referenced Jul 6, 2026
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FIX the issue described in #379 .
Brief changelog
Since the timestamp argument provided to the consumer(beginTimestamp or endTimestamp
) which is later than now is not valid, we should verify them before we actually pull a message from the broker.
And the following are corresponding changes:
By the way, I think we should print report messages in the same style, so I change the messages to capitalized.
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily.
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.