Skip to content

[ISSUE #379] FIX admin subcommand consumeMessage can pull message with timestamp greater than now#380

Merged
vongosling merged 1 commit into
apache:developfrom
xiaozongyang:fix-consume-from-invalid-time
Jul 23, 2018
Merged

[ISSUE #379] FIX admin subcommand consumeMessage can pull message with timestamp greater than now#380
vongosling merged 1 commit into
apache:developfrom
xiaozongyang:fix-consume-from-invalid-time

Conversation

@xiaozongyang

Copy link
Copy Markdown

What is the purpose of the change

FIX the issue described in #379 .

Brief changelog

Since the timestamp argument provided to the consumer(beginTimestamp or endTimestamp
) which is later than now is not valid, we should verify them before we actually pull a message from the broker.
And the following are corresponding changes:

  • Add verification of command line argument beginTimestamp and endTimestamp
  • exit the program if any of the arguments are invalid

By the way, I think we should print report messages in the same style, so I change the messages to capitalized.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exists. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.08%) to 42.389% when pulling e17cbba on XiaoZYang:fix-consume-from-invalid-time into 3f7dda3 on apache:develop.

@vongosling vongosling left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants