[ROCKETMQ-37] Log output information is not accurate#33
Closed
a2888409 wants to merge 2 commits into
Closed
Conversation
Member
|
It seems ok, thanks @a2888409 Please @vongosling @lizhanhui help review this PR. |
lizhanhui
reviewed
Jan 13, 2017
| } else { | ||
| log.warn("Previous MQClientInstance has created for clientId:[{}]", clientId); | ||
| } else { | ||
| log.info("new MQClientInstance has created for clientId:[{}]", clientId); |
Contributor
There was a problem hiding this comment.
It will be better if using active tune here. Something like, Returned previous MQClientInstance for clientId: ..., Created new MQClientInstance for clientId: ...
Contributor
Author
There was a problem hiding this comment.
thanks, i have fixed it.
Member
|
alright |
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
pingww
pushed a commit
that referenced
this pull request
Aug 26, 2022
[ISSUE #33] some thread safety problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue: https://issues.apache.org/jira/browse/ROCKETMQ-37