Skip to content

[ROCKETMQ-37] Log output information is not accurate #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a2888409 wants to merge 2 commits into from
Closed

[ROCKETMQ-37] Log output information is not accurate #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
633eca2
Fix-37 [ROCKETMQ-37] Log output information is not accurate
a2888409 Jan 9, 2017
fe8a7a8
Fix-37 [ROCKETMQ-37] Using active tune for log output
a2888409 Jan 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public void deleteSubscriptionGroupConfig(final String groupName) {
this.dataVersion.nextVersion();
this.persist();
} else {
log.warn("delete subscription group failed, subscription group: {} not exist", old);
log.warn("delete subscription group failed, subscription groupName: {} not exist", groupName);
}
}
}
3 changes: 2 additions & 1 deletion client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ public MQClientInstance getAndCreateMQClientInstance(final ClientConfig clientCo
MQClientInstance prev = this.factoryTable.putIfAbsent(clientId, instance);
if (prev != null) {
instance = prev;
log.warn("Returned Previous MQClientInstance for clientId:[{}]", clientId);
} else {
log.warn("Previous MQClientInstance has created for clientId:[{}]", clientId);
log.info("Created new MQClientInstance for clientId:[{}]", clientId);
}
}

Expand Down