SAMZA-2776: Upgrade Azure libraries in module samza-azure.#1660
Merged
Conversation
Contributor
Author
hshukla
approved these changes
Jun 9, 2023
ehoner
commented
Jun 13, 2023
Comment on lines
+284
to
+285
| ReceiverOptions receiverOptions = new ReceiverOptions(); | ||
| receiverOptions.setPrefetchCount(prefetchCount); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
The
com.azureandcom.microsoftdependencies insamza-azureare outdated. These should be updated to their newest versions. These libraries have undergone significant changes and are available only in their legacy locations.Changes
No changes are made to Samza's public APIs. All changes are required by changes in the updated libraries. No unit tests were changed. An itemized description of the underlying changes is below.
The file
samza-azure/samza-azure-dependencies.txtwas added and removed, intended for review/discussion purposes only [de23888].EventHubClient.java
createSync=>createFromConnectionStringSyncExector=>ScheduledExecutorServiceEventData.java
void setSystemProperties(SystemProperties props);EventData.java.Comparable<EventData>PartitionReceiver.java
void setPrefetchCount(final int prefetchCount) throws EventHubException;RecieverOptionsobject (no functionality lost).Tests
No tests added. All tests are passing.