SAMZA-2776: Fix unused parameter - EventHubSystemConsumer#1670
Merged
Conversation
- Change powermock parameters
ehoner
marked this pull request as ready for review
June 14, 2023 14:27
atoomula
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom: self-reported bug.
Cause: A variable added in #1660 is unused. The parameter sets the offset in the
PartitionReceiver. The change was required because of API changes in the previous PR.Changes: This change was required in two places in the original PR, however, only one was unused. This PR corrects that and updates both sites to a similar code structure.
Tests: No new tests were added. Existing tests did not identify the mistake because the change did not affect the mock used for testing. After the change, the tests failed until the mock was updated.