[SPARK-29203][SQL][TESTS][2.4] Reduce shuffle partitions in SQLQueryTestSuite #25938
Closed
wangyum wants to merge 1 commit into
Closed
[SPARK-29203][SQL][TESTS][2.4] Reduce shuffle partitions in SQLQueryTestSuite #25938wangyum wants to merge 1 commit into
wangyum wants to merge 1 commit into
Conversation
Member
Author
|
Test build #111409 has finished for PR 25938 at commit
|
wangyum
added a commit
that referenced
this pull request
Sep 26, 2019
…estSuite ### What changes were proposed in this pull request? This PR backport #25891 to `branch-2.4`. ### Why are the changes needed? Reduce testing time. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manually tested in my local: Before: ``` ... [info] - subquery/in-subquery/in-joins.sql (6 minutes, 19 seconds) [info] - subquery/in-subquery/not-in-joins.sql (2 minutes, 17 seconds) [info] - subquery/scalar-subquery/scalar-subquery-predicate.sql (45 seconds, 763 milliseconds) ... Run completed in 1 hour, 22 minutes. ``` After: ``` ... [info] - subquery/in-subquery/in-joins.sql (1 minute, 12 seconds) [info] - subquery/in-subquery/not-in-joins.sql (27 seconds, 541 milliseconds) [info] - subquery/scalar-subquery/scalar-subquery-predicate.sql (17 seconds, 360 milliseconds) ... Run completed in 47 minutes. Closes #25938 from wangyum/SPARK-29203-branch-2.4. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Yuming Wang <wgyumg@gmail.com>
Member
Author
|
Merged to branch-2.4. |
Member
|
Thank you! Late LGTM. |
gatorsmile
reviewed
Oct 4, 2019
| private val inputFilePath = new File(baseResourcePath, "inputs").getAbsolutePath | ||
| private val goldenFilePath = new File(baseResourcePath, "results").getAbsolutePath | ||
|
|
||
| override def sparkConf: SparkConf = super.sparkConf |
Member
There was a problem hiding this comment.
This should be protected, right? In the parent trait SharedSparkSession, it is protected.
protected override def sparkConf ....
Member
There was a problem hiding this comment.
Yes, seems adding a protected modifier is correct, though, we don't usually make separate PRs to address minor nits. Since the PR is open, I guess it's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR backport #25891 to
branch-2.4.Why are the changes needed?
Reduce testing time.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested in my local:
Before:
After: