[SPARK-29203][TESTS][Minor][Follow Up] Add access modifier for sparkConf in SQLQueryTestSuite#26019
Closed
xuanyuanking wants to merge 1 commit into
Closed
[SPARK-29203][TESTS][Minor][Follow Up] Add access modifier for sparkConf in SQLQueryTestSuite#26019xuanyuanking wants to merge 1 commit into
xuanyuanking wants to merge 1 commit into
Conversation
xuanyuanking
changed the title
HyukjinKwon
approved these changes
Oct 4, 2019
HyukjinKwon
left a comment
HyukjinKwon
left a comment
Member
There was a problem hiding this comment.
LGTM since the PR is already open; however, it's usually discouraged to make PRs to fix a couple of nits.
|
Test build #111764 has finished for PR 26019 at commit
|
Member
|
Merged to master and branch-2.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 4, 2019
…onf in SQLQueryTestSuite ### What changes were proposed in this pull request? Add access modifier `protected` for `sparkConf` in SQLQueryTestSuite, because in the parent trait SharedSparkSession, it is protected. ### Why are the changes needed? Code consistency. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing UT. Closes #26019 from xuanyuanking/SPARK-29203. Authored-by: Yuanjian Li <xyliyuanjian@gmail.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 93289b5) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Member
Author
|
Thanks, will pay attention next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add access modifier
protectedforsparkConfin SQLQueryTestSuite, because in the parent trait SharedSparkSession, it is protected.Why are the changes needed?
Code consistency.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT.