[SYSTEMDS-3330] Corrections to Generator for f_ functions.#2333
Closed
Baunsgaard wants to merge 2 commits into
Closed
[SYSTEMDS-3330] Corrections to Generator for f_ functions.#2333Baunsgaard wants to merge 2 commits into
Baunsgaard wants to merge 2 commits into
Conversation
This commit resolves some inconsistent behavior in the generation of builtin functions in python generated files. Closes apache#2291
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2333 +/- ##
============================================
- Coverage 72.27% 72.26% -0.02%
+ Complexity 46677 46671 -6
============================================
Files 1501 1501
Lines 177023 177023
Branches 34791 34791
============================================
- Hits 127942 127919 -23
- Misses 39426 39447 +21
- Partials 9655 9657 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves some inconsistent behavior in the generation
of builtin functions in python generated files.
See #2291 for original PR.
This PR is for merging the original.