Added conditional support in xhr#2645
Closed
nithinkdb wants to merge 3 commits into
Closed
Conversation
moderakh
reviewed
Aug 25, 2022
|
|
||
| var xreq = this.getXmlHttpRequestObject(); | ||
|
|
||
| if (this.protocol == TBinaryProtocol) { |
There was a problem hiding this comment.
which binary protocol is this referring to?
databricks thrift uses Http Thrift protocol not Binary thrift protocol. Is this referring to the same conectp?
Author
There was a problem hiding this comment.
Ya, each connection within thrift has an associated protocol for encoding as well as a transport type. We use an HTTP connection within the nodeconnector, and we encode that information with a binary protocol and send it in chunks (bufffered transport).
Member
There was a problem hiding this comment.
For the sake of terminology: HTTP is a transport which can of course be combined with a binary protocol.
Author
|
Hi, any updates on this? Has anyone from the Apache Thrift team taken a look? |
Member
|
rebase needed, no activity since 2022 |
CJCombrink
added a commit
to CJCombrink/thrift
that referenced
this pull request
Mar 12, 2026
- Picking up THRIFT-4987 based on feedback and other PRs and local thrift patches for npm package - Changes most probably originated from apache#2645 and apache#2157 that went stale and PRs were closed
5 tasks
CJCombrink
added a commit
to CJCombrink/thrift
that referenced
this pull request
Mar 13, 2026
- Picking up THRIFT-4987 based on feedback and other PRs and local thrift patches for npm package - Changes most probably originated from apache#2645 and apache#2157 that went stale and PRs were closed
CJCombrink
added a commit
to CJCombrink/thrift
that referenced
this pull request
Mar 17, 2026
- Picking up THRIFT-4987 based on feedback and other PRs and local thrift patches for npm package - Changes most probably originated from apache#2645 and apache#2157 that went stale and PRs were closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of a pull request that was created a while ago. I've replicated the changes, and added an additional check that keeps functionality largely the same while enabling TBinaryProtocol to be used in XHRRequests. This is needed for functionality in one of our thrift projects.
Link to original PR:
#2157
[skip ci]anywhere in the commit message to free up build resources.