Skip to content

Added conditional support in xhr #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nithinkdb wants to merge 3 commits into from
Closed

Added conditional support in xhr #2645

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbaea1a
Added conditional support in xhr
nithinkdb Aug 22, 2022
f05720c
Changed this to self, for state check
nithinkdb Aug 22, 2022
15499b4
Merge branch 'master' into xhr-binary
Jens-G Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/nodejs/lib/thrift/xhr_connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ var util = require("util");
var EventEmitter = require("events").EventEmitter;
var thrift = require("./thrift");

var TBufferedTransport = require("./buffered_transport");
var TJSONProtocol = require("./json_protocol");
var InputBufferUnderrunError = require("./input_buffer_underrun_error");
var TBufferedTransport = require('./buffered_transport');
var TJSONProtocol = require('./json_protocol');
var TBinaryProtocol = require('./binary_protocol');
var InputBufferUnderrunError = require('./input_buffer_underrun_error');

var createClient = require("./create_client");

Expand Down Expand Up @@ -108,13 +109,22 @@ XHRConnection.prototype.flush = function () {

var xreq = this.getXmlHttpRequestObject();

if (this.protocol == TBinaryProtocol) {

@moderakh moderakh Aug 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which binary protocol is this referring to?
databricks thrift uses Http Thrift protocol not Binary thrift protocol. Is this referring to the same conectp?

@nithinkdb nithinkdb Aug 29, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, each connection within thrift has an associated protocol for encoding as well as a transport type. We use an HTTP connection within the nodeconnector, and we encode that information with a binary protocol and send it in chunks (bufffered transport).

@Jens-G Jens-G Aug 29, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of terminology: HTTP is a transport which can of course be combined with a binary protocol.

xreq.responseType = 'arraybuffer';
}

if (xreq.overrideMimeType) {
xreq.overrideMimeType("application/json");
}

xreq.onreadystatechange = function () {
if (this.readyState == 4 && this.status == 200) {
self.setRecvBuffer(this.responseText);
if(self.protocol == TBinaryProtocol) {
self.setRecvBuffer(this.response);
}
else {
self.setRecvBuffer(this.responseText);
}
}
};

Expand Down
Loading