Skip to content

[CI] Update the expected CI jobs list in the update_branch script #14908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 1 commit into from
May 26, 2023
Merged

[CI] Update the expected CI jobs list in the update_branch script #14908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ci/scripts/github/update_branch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,22 @@ def commits_query(user: str, repo: str, cursor: str = None):
"""


EXPECTED_CI_JOBS = [
"cross-isa-minimal/branch",
"gpu/branch",
"hexagon/branch",
"arm/branch",
"cortexm/branch",
"cpu/branch",
"docker/branch",
"i386/branch",
"lint/branch",
"minimal/branch",
"riscv/branch",
"wasm/branch",
]


def commit_passed_ci(commit: Dict[str, Any]) -> bool:
"""
Returns true if all of a commit's statuses are SUCCESS
Expand All @@ -111,9 +127,8 @@ def commit_passed_ci(commit: Dict[str, Any]) -> bool:

# Assert that specific jobs are present in the commit statuses (i.e. don't
# approve if CI was broken and didn't schedule a job)
expected_jobs = {"tvm-ci/branch"}
job_names = {name for name, status in unified_statuses}
for job in expected_jobs:
for job in EXPECTED_CI_JOBS:
if job not in job_names:
# Did not find expected job name
return False
Expand Down
49 changes: 16 additions & 33 deletions tests/python/ci/test_ci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
import scripts.github
import scripts.jenkins

from scripts.github.update_branch import EXPECTED_CI_JOBS

# pylint: enable=wrong-import-position,wrong-import-order


Expand Down Expand Up @@ -434,8 +436,12 @@ def test_cc_reviewers(
assert f"After filtering existing reviewers, adding: {expected_reviewers}" in proc.stdout


def generate_good_commit_status():
return list([{"context": context, "state": "SUCCESS"} for context in EXPECTED_CI_JOBS])


@parameterize_named(
# Missing expected tvm-ci/branch test
# Missing expected gpu/branch test
missing_tvm_ci_branch=dict(
statuses=[
{
Expand All @@ -448,48 +454,25 @@ def test_cc_reviewers(
),
# Only has the right passing test
has_expected_test=dict(
statuses=[
{
"context": "tvm-ci/branch",
"state": "SUCCESS",
}
],
statuses=generate_good_commit_status(),
expected_rc=0,
expected_output="Found last good commit: 123: hello",
),
# Check with many statuses
many_statuses=dict(
statuses=[
{
"context": "tvm-ci/branch",
"state": "SUCCESS",
},
{
"context": "tvm-ci/branch2",
"state": "SUCCESS",
},
{
"context": "tvm-ci/branch3",
"state": "FAILED",
},
statuses=generate_good_commit_status()
+ [
{"context": "gpu/branch2", "state": "SUCCESS"},
{"context": "gpu/branch3", "state": "FAILED"},
],
expected_rc=1,
expected_output="No good commits found in the last 1 commits",
),
many_success_statuses=dict(
statuses=[
{
"context": "tvm-ci/branch",
"state": "SUCCESS",
},
{
"context": "tvm-ci/branch2",
"state": "SUCCESS",
},
{
"context": "tvm-ci/branch3",
"state": "SUCCESS",
},
statuses=generate_good_commit_status()
+ [
{"context": "gpu/branch2", "state": "SUCCESS"},
{"context": "gpu/branch3", "state": "SUCCESS"},
],
expected_rc=0,
expected_output="Found last good commit: 123: hello",
Expand Down