[IR] Make sure Range types match when binding to Var#15909
Closed
kparzysz-quic wants to merge 3 commits intoapache:mainfrom
Closed
[IR] Make sure Range types match when binding to Var#15909kparzysz-quic wants to merge 3 commits intoapache:mainfrom
kparzysz-quic wants to merge 3 commits intoapache:mainfrom
Conversation
The values of `min` and `extent` in Range should have the same type, but the usage of convenience may often produce type mismatches, for example `Range(0, dim)` will assume int32 for the min. These mismatches can then cause hard-to-track errors, in particular assertions in the arithmetic simplifier. Such problems are likely to occur when a mismatched range is bound to a variable. This patch identifies a few occurrences where a Range is bound to a Var, and checks that all types match. In case of a mismatch, types of compile- time immediates can be adjusted, otherwise an error is reported.
Contributor
Author
|
This is a replacement PR for #15909. |
Member
|
Ah I just merged a PR #16074, but not sure if it's related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values of
minandextentin Range should have the same type, but the usage of convenience may often produce type mismatches, for exampleRange(0, dim)will assume int32 for the min. These mismatches can then cause hard-to-track errors, in particular assertions in the arithmetic simplifier. Such problems are likely to occur when a mismatched range is bound to a variable.This patch identifies a few occurrences where a Range is bound to a Var, and checks that all types match. In case of a mismatch, types of compile- time immediates can be adjusted, otherwise an error is reported.