[TIR] Fix the thread binding iter_var dtype in Bind primitive#16074
Merged
junrushao merged 1 commit intoapache:mainfrom Nov 5, 2023
Merged
[TIR] Fix the thread binding iter_var dtype in Bind primitive#16074junrushao merged 1 commit intoapache:mainfrom
Bind primitive#16074junrushao merged 1 commit intoapache:mainfrom
Conversation
junrushao
approved these changes
Nov 5, 2023
As a follow up PR of apache#16041, this PR fixes the iter_var dtype generated by the schedule primitive `bind`. Now the iter_var dtype is the same as the loop_var. Note that this PR changes the internal interface (tir interface) of the bind primitive. But it does not change the user interface (python side, and concrete_schedule.cc side).
5ca3745 to
f329be4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up PR of #16041, this PR fixes the iter_var dtype generated by the schedule primitive
bind. Now the iter_var dtype is the same as the loop_var.Note that this PR changes the internal interface (tir interface) of the bind primitive. But it does not change the user interface (python side, and concrete_schedule.cc side).
cc @junrushao