Skip to content

[Relax] Replace topi.take with relax.op.take #18665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlopex merged 2 commits into from
Jan 16, 2026
Merged

[Relax] Replace topi.take with relax.op.take #18665

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fdb1e3
Replace topi.take with relax.op.take
guan404ming Jan 16, 2026
8c707a5
Fix lint
guan404ming Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions python/tvm/relax/frontend/onnx/onnx_frontend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3161,11 +3161,10 @@ def _impl_v1(cls, bb, inputs, attr, params):

if pos_ids is None:
pos_ids = relax.const([list(range(seq_len))] * batch_size, dtype="int64")
# TODO(jwfromm) Replace with relax ops once take has better support.
word_vec = bb.emit_te(topi.take, word_emb, input_ids, 0)
word_vec = relax.op.take(word_emb, input_ids, axis=0)
if segment_ids:
segment_vec = bb.emit_te(topi.take, segment_emb, segment_ids, 0)
pos_vec = bb.emit_te(topi.take, pos_emb, pos_ids, 0)
segment_vec = relax.op.take(segment_emb, segment_ids, axis=0)
pos_vec = relax.op.take(pos_emb, pos_ids, axis=0)

vec_sum = relax.op.add(word_vec, pos_vec)
if segment_ids:
Expand Down Expand Up @@ -3323,15 +3322,11 @@ def _impl_v11(cls, bb, inputs, attr, params):
mode = attr.get("mode", b"DCR").decode("utf-8")
b, c, h, w = inputs[0].struct_info.shape
if mode == "DCR":
x = relax.op.reshape(
inputs[0], (b, block_size, block_size, c // (block_size**2), h, w)
)
x = relax.op.reshape(inputs[0], (b, block_size, block_size, c // (block_size**2), h, w))
x = relax.op.permute_dims(x, [0, 3, 4, 1, 5, 2])
return relax.op.reshape(x, (b, c // (block_size**2), h * block_size, w * block_size))
elif mode == "CRD":
x = relax.op.reshape(
inputs[0], (b, c // (block_size**2), block_size, block_size, h, w)
)
x = relax.op.reshape(inputs[0], (b, c // (block_size**2), block_size, block_size, h, w))
x = relax.op.permute_dims(x, [0, 1, 4, 2, 5, 3])
return relax.op.reshape(x, (b, c // (block_size**2), h * block_size, w * block_size))
else:
Expand Down
Loading