[Fix] Fix get_valid_count flaky test for cuda#4901
Merged
yzhliu merged 10 commits intoapache:masterfrom Feb 21, 2020
Merged
Conversation
trevor-m
requested changes
Feb 18, 2020
Contributor
trevor-m
left a comment
trevor-m
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
trevor-m
approved these changes
Feb 19, 2020
Contributor
Author
|
ping @kevinthesun @yzhliu |
yzhliu
approved these changes
Feb 21, 2020
Member
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
* get_valid_count accuracy issue fixed for individual tests but not for all tests running together * minor fix * initialize valid_count and PrefixSum buffers * test updated * udpate relay test as well * update document * fix lint * address comment * fix lint * correct atomicAdd identifier name
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
* get_valid_count accuracy issue fixed for individual tests but not for all tests running together * minor fix * initialize valid_count and PrefixSum buffers * test updated * udpate relay test as well * update document * fix lint * address comment * fix lint * correct atomicAdd identifier name
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
* get_valid_count accuracy issue fixed for individual tests but not for all tests running together * minor fix * initialize valid_count and PrefixSum buffers * test updated * udpate relay test as well * update document * fix lint * address comment * fix lint * correct atomicAdd identifier name
Member
|
@Laurawly I still get a flaky failure from get_valid_count test in my PR |
Contributor
Author
|
@masahi That’s weird. You can comment off the test for now and I’ll try to reproduce it on my end. |
Member
|
@Laurawly Also reported at a different PR #4931 (comment) |
Contributor
Author
Yeah, pls feel free to comment out the test: https://github.com/apache/incubator-tvm/blob/master/topi/tests/python/test_topi_vision.py#L106 |
Member
|
fortunately my PR is green now without commenting out :) If the next open PR by somebody else sees the same problem, I'll ask him/her to comment it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned on get_valid_count test for cuda in topi. Used atomic operations in this fix to replace previous block sync method.
Tested on V100 and T4 GPUs.
@trevor-m @kevinthesun @yzhliu Could you review?