[VTA][Chisel] Change Scala Linter scalafmt => scalastyle#4998
Merged
tmoreau89 merged 4 commits intoapache:masterfrom Mar 7, 2020
Merged
[VTA][Chisel] Change Scala Linter scalafmt => scalastyle#4998tmoreau89 merged 4 commits intoapache:masterfrom
tmoreau89 merged 4 commits intoapache:masterfrom
Conversation
Change-Id: Ifc590e7cb63585f35dfdc9efcf3c6287b1afb1dd
Change-Id: I8aff2632dadda05d2896e28bdaf6f780a160a15a
Contributor
|
Thanks @liangfu ; let us know when it's ready for a merge. |
Member
Author
|
@tmoreau89 @vegaluisjose Thanks for the review. I think this is now ready for a merge, and let's wait for the CI testing results. |
Change-Id: Ibeb00c11a5718ea47322ea2b82e757828af8af91
Member
Author
|
In addition, based on the suggestions in the linter, I made some final changes in fixing indentation errors, here is a typical example: diff --git a/vta/hardware/chisel/src/main/scala/core/Load.scala b/vta/hardware/chisel/src/main/scala/core/Load.scala
index 7c79498bd..50c26bb8e 100644
--- a/vta/hardware/chisel/src/main/scala/core/Load.scala
+++ b/vta/hardware/chisel/src/main/scala/core/Load.scala
@@ -25,12 +25,12 @@ import vta.util.config._
import vta.shell._
/** Load.
- *
- * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
- * This module instantiate the TensorLoad unit which is in charge of
- * loading 1D and 2D tensors to scratchpads, so it can be used by
- * other modules such as Compute.
- */
+ *
+ * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
+ * This module instantiate the TensorLoad unit which is in charge of
+ * loading 1D and 2D tensors to scratchpads, so it can be used by
+ * other modules such as Compute.
+ */
class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
val mp = p(ShellKey).memParams
val io = IO(new Bundle {
@@ -110,11 +110,10 @@ class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
when(dec.io.isSync) {
printf("[Load] start sync\n")
}.elsewhen(dec.io.isInput) {
- printf("[Load] start input\n")
- }
- .elsewhen(dec.io.isWeight) {
- printf("[Load] start weight\n")
- }
+ printf("[Load] start input\n")
+ }.elsewhen(dec.io.isWeight) {
+ printf("[Load] start weight\n")
+ }
}
// done
when(state === sSync) {Please take another look. |
vegaluisjose
approved these changes
Mar 6, 2020
Contributor
|
Thanks for the diff @liangfu ; this looks great. |
Contributor
|
Looks like CI failed on one of the unit tests |
Member
Author
|
I think it might related to #4901 , let me trigger the testing pipeline again. |
Contributor
|
Thanks @liangfu, @vegaluisjose the PR has been merged! |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
* scalafmt => scalastyle Change-Id: Ifc590e7cb63585f35dfdc9efcf3c6287b1afb1dd * scalafmt => scalastyle Change-Id: I8aff2632dadda05d2896e28bdaf6f780a160a15a * add indentation constraint Change-Id: Ibeb00c11a5718ea47322ea2b82e757828af8af91 * trigger ci again
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* scalafmt => scalastyle Change-Id: Ifc590e7cb63585f35dfdc9efcf3c6287b1afb1dd * scalafmt => scalastyle Change-Id: I8aff2632dadda05d2896e28bdaf6f780a160a15a * add indentation constraint Change-Id: Ibeb00c11a5718ea47322ea2b82e757828af8af91 * trigger ci again
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* scalafmt => scalastyle Change-Id: Ifc590e7cb63585f35dfdc9efcf3c6287b1afb1dd * scalafmt => scalastyle Change-Id: I8aff2632dadda05d2896e28bdaf6f780a160a15a * add indentation constraint Change-Id: Ibeb00c11a5718ea47322ea2b82e757828af8af91 * trigger ci again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As scalafmt changes the code even with
--testargument in the latest version, this PR switches scala linter for Chisel VTA from scalafmt to scalastyle.@tmoreau89 @vegaluisjose Please review.