[ZEPPELIN-954] Fix table cell selection problem on second run by properly destroying hot.#1059
Closed
jasonxh wants to merge 3 commits into
Closed
[ZEPPELIN-954] Fix table cell selection problem on second run by properly destroying hot.#1059jasonxh wants to merge 3 commits into
jasonxh wants to merge 3 commits into
Conversation
Also make cells readonly. Previously one were able to paste into them.
jasonxh
changed the title
Member
|
Tested both cases, looks good to me 👍 |
Member
|
\cc @corneadoug for review |
| var renderTable = function() { | ||
| var height = $scope.paragraph.config.graph.height; | ||
| angular.element('#p' + $scope.paragraph.id + '_table').css('height', height); | ||
| var container = angular.element('#p' + $scope.paragraph.id + '_table').css('height', height).get(0); |
Contributor
There was a problem hiding this comment.
Tested, works great, but could we keep those two actions separated?
Contributor
Author
There was a problem hiding this comment.
i figured we could just start using the return value and save an extra lookup for the same selector. pls let me know if you have strong preference and i can revert this line.
Contributor
|
Tested, No more handsontable duplicates. |
Contributor
Author
|
@corneadoug good suggestion. i updated the pr to reuse the table when possible. |
Member
|
Merge it there is no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2016
…erly destroying hot. ### What is this PR for? * Fix table cell selection problem on second run by properly destroying hot. * Also make cells readonly. Previously one were able to paste into them. ### What type of PR is it? [Bug Fix] ### Todos ### What is the Jira issue? * [ZEPPELIN-954] ### How should this be tested? Execute the following paragraph multiple times, and verify the table cells are still selectable. ``` %sh echo %table echo -e "col1\tcol2\tcol3" echo -e "1\t2.1\tabcdefg" ``` Also try to paste anything into a cell to no avail. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Hao Xia <hao@optimizely.com> Closes #1059 from jasonxh/hao/hot-fix and squashes the following commits: 38d3ef4 [Hao Xia] Use the data argument consistently 1eb7fe4 [Hao Xia] Reuse the table when possible 5bd9502 [Hao Xia] Fix selection problem on second run by properly destroying hot. Also make cells readonly. Previously one were able to paste into them. (cherry picked from commit e1b3847) Signed-off-by: Mina Lee <minalee@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jul 19, 2016
### What is this PR for? Handsontable fails to display data on second run if first run did not render table due to an error in the query. Fix for a render issue caused by #1059 ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1170 ### How should this be tested? Please ref the screenshots ### Screenshots (if appropriate) **Before**  **After**  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith Kamath <renjith.kamath@gmail.com> Closes #1182 from r-kamath/ZEPPELIN-1170 and squashes the following commits: 6f0f591 [Renjith Kamath] Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1170 d63d517 [Renjith Kamath] ZEPPELIN-1170 Handsontable fails to display data on second run
asfgit
pushed a commit
that referenced
this pull request
Jul 19, 2016
Handsontable fails to display data on second run if first run did not render table due to an error in the query. Fix for a render issue caused by #1059 Bug Fix https://issues.apache.org/jira/browse/ZEPPELIN-1170 Please ref the screenshots **Before**  **After**  * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith Kamath <renjith.kamath@gmail.com> Closes #1182 from r-kamath/ZEPPELIN-1170 and squashes the following commits: 6f0f591 [Renjith Kamath] Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1170 d63d517 [Renjith Kamath] ZEPPELIN-1170 Handsontable fails to display data on second run (cherry picked from commit 8ffd9af) Signed-off-by: Mina Lee <minalee@apache.org> Conflicts: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Handsontable fails to display data on second run if first run did not render table due to an error in the query. Fix for a render issue caused by apache#1059 ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1170 ### How should this be tested? Please ref the screenshots ### Screenshots (if appropriate) **Before**  **After**  ### Questions: * Does the licenses files need update? n/a * Is there breaking changes for older versions? n/a * Does this needs documentation? n/a Author: Renjith Kamath <renjith.kamath@gmail.com> Closes apache#1182 from r-kamath/ZEPPELIN-1170 and squashes the following commits: 6f0f591 [Renjith Kamath] Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1170 d63d517 [Renjith Kamath] ZEPPELIN-1170 Handsontable fails to display data on second run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Execute the following paragraph multiple times, and verify the table cells are still selectable.
Also try to paste anything into a cell to no avail.
Screenshots (if appropriate)
Questions: