ZEPPELIN-1170 Handsontable fails to display data on second run

[r-kamath]

What is this PR for?

Handsontable fails to display data on second run if first run did not render table due to an error in the query.
Fix for a render issue caused by #1059

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1170

How should this be tested?

Please ref the screenshots

Screenshots (if appropriate)

Before

After

Questions:

• Does the licenses files need update? n/a
• Is there breaking changes for older versions? n/a
• Does this needs documentation? n/a

[Leemoonsoo]

@r-kamath Thanks for the fix. How this fix is different from #1171 ?

[prabhjyotsingh]

LGTM!

This has been happening in my machine as well for quite some time. Thanks @r-kamath for the fix.

@corneadoug, @Leemoonsoo Please review will merge this a hot fix.

[r-kamath]

@Leemoonsoo My bad, I missed your PR.
Difference in #1171 and this pr

• $scope.hot = null; is not necessary
• updateSettings to update resultRows is one more call and is not doing anything significant
  Otherwise the change is pretty much same.

[r-kamath]

@Leemoonsoo if #1171 is ready to merge. Please feel free to discard this PR and mark the jira issue as duplicate. Thanks :)

[Leemoonsoo]

I think we can merge #1171 and then merge #1182, while this PR includes different improvements. ($scope.hot = null and updateSettings)

I didn't marked #1171 as a hotfix, but let me merge #1171 quickly, and then let's merge #1182.

[prabhjyotsingh]

@Leemoonsoo Yes, I agree, we should merge #1171.

[bzz]

So what is the consensus, shall we actually rebase this one on master and merge, or just close, as soon as #1171 is merged?

[corneadoug]

#1171 is merged already, and this one has been rebased

[bzz]

@corneadoug from what you say, it's still not clear what's the plan with this one.

I do not think it was rebased, where rebased = git rebase - that way all the commits would show up AFTER the conversation as history gets re-written.

Also we would not have commit messages like "Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1170" in case of rebase.

[corneadoug]

Tested, LGTM

[corneadoug]

Merging if there is no more discussions