[ZEPPELIN-3377] Passing Z variables to JDBC interpreter by sanjaydasgupta · Pull Request #2903 · apache/zeppelin

sanjaydasgupta · 2018-04-02T07:07:13Z

What is this PR for?

This PR enables the interpolation of ZeppelinContext objects into the paragraph text of JDBC cells. It also introduces a new interpreter-level configuration parameter named zeppelin.jdbc.interpolation. This new parameter is false by default, and must be set to true to enable object interpolation. The default value of false guarantees backward compatibility for users who are not aware of the new feature.

The implementation takes the same approach that was followed in PR-2898.

I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation (jdbc.md).

What type of PR is it?

[Feature]

Todos

- Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3377

How should this be tested?

CI Pass.

The code in this PR merely causes the JDBC interpreter to "opt-in" to the implementation already existing in the Interpreter base class - described in PR-2898. The unit tests necessary are already present in PR-2898

Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes, documentation has been added to the file jdbc.md. I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation.

…ELIN-1967

…owing #2834 (comment)

…ELIN-1967

…ppelin/pull/2834/files/1e2c87dd36dc091ca898baf8e9f178d6d1a5e600#r176930418

…ELIN-1967

…Jeff Zhang's subsequent clarification

…ELIN-1967

…elin-3342-hdfs

felixcheung · 2018-04-03T06:15:03Z

 SELECT name, country, performer
 FROM demo.performers
-WHERE name='{{"{{performer=Sheryl Crow|Doof|Fanfarlo|Los Paranoia"}}}}'
+WHERE name='${performer=Sheryl Crow|Doof|Fanfarlo|Los Paranoia}'


I think this is different, right, why this change?

Yes, this is a different thing. I have mentioned under What is this PR for?:

I have also taken the liberty to correct a preexisting error in the description of the use of
Dynamic Forms in the associated documentation (jdbc.md).

Since I was editing jdbc.md, I thought correcting the error would be useful for readers. The changed text works as intended under the current implementation, and is also according to the documentation for Dynamic Forms.

Please let me know if corrections should be handled in a different way.

Thanks for noticing this update.

sanjaydasgupta · 2018-04-07T02:18:20Z

@felixcheung Please note my response to your earlier question about the unrelated documentation change.

Please let me know if there are any other concerns. Thanks.

felixcheung

is there test we could add for this?

felixcheung · 2018-04-08T06:52:59Z

 </table>

 [Maven Repository: org.apache.tajo:tajo-jdbc](https://mvnrepository.com/artifact/org.apache.tajo/tajo-jdbc)
+## Object Interpolation


I think you need an empty line before ## or it will not be treated as header properly

Added preceding blank line.

felixcheung · 2018-04-08T06:54:19Z

+```
+
+####In later JDBC cell:
+```


add sql - see L230

Added the 'sql'

felixcheung · 2018-04-08T06:54:58Z

+
+####In later JDBC cell:
+```
+%jdbc_interpreter_name select * from patents_list where 


newline after %jdbc_interpreter_name for clarity & consistency with other example?

felixcheung · 2018-04-08T06:55:48Z

+####In later JDBC cell:
+```
+%jdbc_interpreter_name select * from patents_list where 
+    priority_country = '{country_code}' and filing_date like '2015-__-__'


is _ in 2015-__-__ intentional?
perhaps better if the example is 2015-%? or just pick 2015-01-01

I've preferred '2015-%' as using '2015-01-01' would retrieve a too small sample - and not be a realistic example.

sanjaydasgupta · 2018-04-08T17:05:25Z

@felixcheung I've fixed the 4 issues in the documentation file jdbc.md, thanks for the very careful review.

I have also added a unit test JDBCInterpreterInterpolationTest.java which tests the following:

enabling and disabling the feature by setting "zeppelin.jdbc.interpolation", including the default value of false.
normal substitution of {...} patterns
escaping the pattern functionality by using {{...}}

Please also note that all the unit tests defined for this feature in the Interpreter base class do a thorough check of all possible uses and misuses of { and }. The above additional unit test is really more like an integration test to verify that the JDBC interpreter is inheriting and leveraging the base class's functionality correctly.

Thanks for your very helpful review.

felixcheung

LGTM, thanks!

could you check the test failure though
https://travis-ci.org/sanjaydasgupta/zeppelin/builds/363808230

sanjaydasgupta · 2018-04-09T03:11:29Z

Apologies for missing the check style errors @felixcheung

The style issues in JDBCInterpreterInterpolationTest.java have been removed, and all the tests now pass. The other failures in the build are unrelated to this feature.

Thanks for your review.

sanjaydasgupta · 2018-04-11T00:21:46Z

Hi @felixcheung, can these changes be merged now?

felixcheung · 2018-04-11T06:49:47Z

still have errors on this link https://travis-ci.org/sanjaydasgupta/zeppelin/builds/363808230?

Revision after Felix Cheung's comment at #2903 (comment)

After Felix Cheung's comments at #2903 (comment)

sanjaydasgupta · 2018-04-11T13:58:07Z

Oops! I must have messed up somewhere!

I've corrected the style issues now @felixcheung, and the one remaining failure appears to be a build script problem unrelated to my code.

Thanks!

sanjaydasgupta · 2018-04-16T17:49:52Z

ping @felixcheung

sanjaydasgupta · 2018-04-22T08:55:10Z

Closing and reopening to trigger tests.

sanjaydasgupta · 2018-04-22T15:51:10Z

Hi @felixcheung please let me know if any additional changes or adjustments are needed.

The two failing tests are unrelated to the code in in this PR

Thanks.

felixcheung · 2018-04-23T04:44:26Z

looks good!
merging if no more comment

sanjaydasgupta · 2018-04-27T07:48:14Z

Hi @felixcheung is it possible to release this into 0.8.0?

Thanks

felixcheung · 2018-04-28T06:04:18Z

I think so, @zjffdu what do you think about this in 0.8?

### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text of JDBC cells. It also introduces a new interpreter-level configuration parameter named _zeppelin.jdbc.interpolation_. This new parameter is _false_ by default, and must be set to _true_ to enable object interpolation. The default value of _false_ guarantees backward compatibility for users who are not aware of the new feature. The implementation takes the same approach that was followed in [PR-2898](#2898). I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation (_jdbc.md_). ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3377 ### How should this be tested? CI Pass. The code in this PR merely causes the JDBC interpreter to "opt-in" to the implementation already existing in the `Interpreter` base class - described in [PR-2898](#2898). The unit tests necessary are already present in PR-2898 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, documentation has been added to the file _jdbc.md_. I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation. Author: Sanjay Dasgupta <sanjay.dasgupta@gmail.com> Author: Sanjay Dasgupta <sanjaydasgupta@users.noreply.github.com> Closes #2903 from sanjaydasgupta/zeppelin-3342-jdbc and squashes the following commits: 9947d36 [Sanjay Dasgupta] Expanded * imports to remove check-style errors 094d3ce [Sanjay Dasgupta] Reduced indentation to remove check-style errors 07561f5 [Sanjay Dasgupta] Revisions after Felix Cheung's review #2903 (review) df99ab0 [Sanjay Dasgupta] Revisions after Felix Cheung's review #2903 (review) 315a9ad [Sanjay Dasgupta] Corrected use of rlike in SQL statement eb9194d [Sanjay Dasgupta] ZEPPELIN-3377 Updates Initial Load 0f49867 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into zeppelin-3342-hdfs a19e998 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 77738aa [Sanjay Dasgupta] Changes to comply with Felix Cheung's comment at #2834 (comment) and Jeff Zhang's subsequent clarification 5f8505b [Sanjay Dasgupta] Changes due to Felix Cheung's comments at #2834 (review) d600d86 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 cc3727f [Sanjay Dasgupta] Changes due the Jeff Zhang's comments at https://github.com/apache/zeppelin/pull/2834/files/1e2c87dd36dc091ca898baf8e9f178d6d1a5e600#r176930418 1e2c87d [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 3dd3dd8 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 a1703b8 [Sanjay Dasgupta] Changes suggested in Felix Cheung's review #2834 (review) b7ddf6b [Sanjay Dasgupta] Implementing configuration (global enable/disable interpolation) following #2834 (comment) 5268803 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 1718e79 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 3b30ea2 [Sanjay Dasgupta] Reversing previous incorrect update 3beebce [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 f43fd99 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 a3215fc [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 ced295c [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 b461c82 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 2868825 [Sanjay Dasgupta] ZEPPELIN-1967: Initial updates (cherry picked from commit e65f730) Signed-off-by: Felix Cheung <felixcheung@apache.org>

felixcheung · 2018-04-28T06:13:46Z

merged this to master & 0.8

### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text of JDBC cells. It also introduces a new interpreter-level configuration parameter named _zeppelin.jdbc.interpolation_. This new parameter is _false_ by default, and must be set to _true_ to enable object interpolation. The default value of _false_ guarantees backward compatibility for users who are not aware of the new feature. The implementation takes the same approach that was followed in [PR-2898](apache#2898). I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation (_jdbc.md_). ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3377 ### How should this be tested? CI Pass. The code in this PR merely causes the JDBC interpreter to "opt-in" to the implementation already existing in the `Interpreter` base class - described in [PR-2898](apache#2898). The unit tests necessary are already present in PR-2898 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, documentation has been added to the file _jdbc.md_. I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation. Author: Sanjay Dasgupta <sanjay.dasgupta@gmail.com> Author: Sanjay Dasgupta <sanjaydasgupta@users.noreply.github.com> Closes apache#2903 from sanjaydasgupta/zeppelin-3342-jdbc and squashes the following commits: 9947d36 [Sanjay Dasgupta] Expanded * imports to remove check-style errors 094d3ce [Sanjay Dasgupta] Reduced indentation to remove check-style errors 07561f5 [Sanjay Dasgupta] Revisions after Felix Cheung's review apache#2903 (review) df99ab0 [Sanjay Dasgupta] Revisions after Felix Cheung's review apache#2903 (review) 315a9ad [Sanjay Dasgupta] Corrected use of rlike in SQL statement eb9194d [Sanjay Dasgupta] ZEPPELIN-3377 Updates Initial Load 0f49867 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into zeppelin-3342-hdfs a19e998 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 77738aa [Sanjay Dasgupta] Changes to comply with Felix Cheung's comment at apache#2834 (comment) and Jeff Zhang's subsequent clarification 5f8505b [Sanjay Dasgupta] Changes due to Felix Cheung's comments at apache#2834 (review) d600d86 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 cc3727f [Sanjay Dasgupta] Changes due the Jeff Zhang's comments at https://github.com/apache/zeppelin/pull/2834/files/1e2c87dd36dc091ca898baf8e9f178d6d1a5e600#r176930418 1e2c87d [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 3dd3dd8 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 a1703b8 [Sanjay Dasgupta] Changes suggested in Felix Cheung's review apache#2834 (review) b7ddf6b [Sanjay Dasgupta] Implementing configuration (global enable/disable interpolation) following apache#2834 (comment) 5268803 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 1718e79 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 3b30ea2 [Sanjay Dasgupta] Reversing previous incorrect update 3beebce [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 f43fd99 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 a3215fc [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 ced295c [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 b461c82 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 2868825 [Sanjay Dasgupta] ZEPPELIN-1967: Initial updates

### What is this PR for? This PR enables the interpolation of ZeppelinContext objects into the paragraph text of JDBC cells. It also introduces a new interpreter-level configuration parameter named _zeppelin.jdbc.interpolation_. This new parameter is _false_ by default, and must be set to _true_ to enable object interpolation. The default value of _false_ guarantees backward compatibility for users who are not aware of the new feature. The implementation takes the same approach that was followed in [PR-2898](apache#2898). I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation (_jdbc.md_). ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3377 ### How should this be tested? CI Pass. The code in this PR merely causes the JDBC interpreter to "opt-in" to the implementation already existing in the `Interpreter` base class - described in [PR-2898](apache#2898). The unit tests necessary are already present in PR-2898 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, documentation has been added to the file _jdbc.md_. I have also taken the liberty to correct a preexisting error in the description of the use of Dynamic Forms in the associated documentation. Author: Sanjay Dasgupta <sanjay.dasgupta@gmail.com> Author: Sanjay Dasgupta <sanjaydasgupta@users.noreply.github.com> Closes apache#2903 from sanjaydasgupta/zeppelin-3342-jdbc and squashes the following commits: 9947d36 [Sanjay Dasgupta] Expanded * imports to remove check-style errors 094d3ce [Sanjay Dasgupta] Reduced indentation to remove check-style errors 07561f5 [Sanjay Dasgupta] Revisions after Felix Cheung's review apache#2903 (review) df99ab0 [Sanjay Dasgupta] Revisions after Felix Cheung's review apache#2903 (review) 315a9ad [Sanjay Dasgupta] Corrected use of rlike in SQL statement eb9194d [Sanjay Dasgupta] ZEPPELIN-3377 Updates Initial Load 0f49867 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into zeppelin-3342-hdfs a19e998 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 77738aa [Sanjay Dasgupta] Changes to comply with Felix Cheung's comment at apache#2834 (comment) and Jeff Zhang's subsequent clarification 5f8505b [Sanjay Dasgupta] Changes due to Felix Cheung's comments at apache#2834 (review) d600d86 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 cc3727f [Sanjay Dasgupta] Changes due the Jeff Zhang's comments at https://github.com/apache/zeppelin/pull/2834/files/1e2c87dd36dc091ca898baf8e9f178d6d1a5e600#r176930418 1e2c87d [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 3dd3dd8 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 a1703b8 [Sanjay Dasgupta] Changes suggested in Felix Cheung's review apache#2834 (review) b7ddf6b [Sanjay Dasgupta] Implementing configuration (global enable/disable interpolation) following apache#2834 (comment) 5268803 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 1718e79 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 3b30ea2 [Sanjay Dasgupta] Reversing previous incorrect update 3beebce [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 f43fd99 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 a3215fc [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 ced295c [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 b461c82 [Sanjay Dasgupta] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1967 2868825 [Sanjay Dasgupta] ZEPPELIN-1967: Initial updates (cherry picked from commit e65f730) Signed-off-by: Felix Cheung <felixcheung@apache.org>

sanjaydasgupta added 21 commits March 4, 2018 13:06

ZEPPELIN-1967: Initial updates

2868825

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

b461c82

…ELIN-1967

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

ced295c

…ELIN-1967

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

a3215fc

…ELIN-1967

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

f43fd99

…ELIN-1967

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

3beebce

…ELIN-1967

Reversing previous incorrect update

3b30ea2

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

1718e79

…ELIN-1967

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

5268803

…ELIN-1967

Implementing configuration (global enable/disable interpolation) foll…

b7ddf6b

…owing #2834 (comment)

Changes suggested in Felix Cheung's review #2834 (review)

a1703b8

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

3dd3dd8

…ELIN-1967

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

1e2c87d

…ELIN-1967

Changes due the Jeff Zhang's comments at https://github.com/apache/ze…

cc3727f

…ppelin/pull/2834/files/1e2c87dd36dc091ca898baf8e9f178d6d1a5e600#r176930418

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

d600d86

…ELIN-1967

Changes due to Felix Cheung's comments at #2834 (review)

5f8505b

Changes to comply with Felix Cheung's comment at #2834 (comment) and …

77738aa

…Jeff Zhang's subsequent clarification

Merge branch 'master' of https://github.com/apache/zeppelin into ZEPP…

a19e998

…ELIN-1967

Merge branch 'master' of https://github.com/apache/zeppelin into zepp…

0f49867

…elin-3342-hdfs

ZEPPELIN-3377 Updates Initial Load

eb9194d

Corrected use of rlike in SQL statement

315a9ad

felixcheung reviewed Apr 3, 2018

View reviewed changes

felixcheung reviewed Apr 8, 2018

View reviewed changes

sanjaydasgupta added 2 commits April 8, 2018 22:07

Revisions after Felix Cheung's review #2903 (review)

df99ab0

Revisions after Felix Cheung's review #2903 (review)

07561f5

felixcheung reviewed Apr 8, 2018

View reviewed changes

sanjaydasgupta added 2 commits April 11, 2018 16:03

Reduced indentation to remove check-style errors

094d3ce

Revision after Felix Cheung's comment at #2903 (comment)

Expanded * imports to remove check-style errors

9947d36

After Felix Cheung's comments at #2903 (comment)

sanjaydasgupta closed this Apr 22, 2018

sanjaydasgupta reopened this Apr 22, 2018

asfgit closed this in e65f730 Apr 28, 2018

This was referenced May 14, 2018

[ZEPPELIN-3438] Passing Z variables to BigQuery interpreter #2967

Closed

ZEPPELIN-3379 Refactoring of JDBC autocomplete. #2970

Closed

sanjaydasgupta mentioned this pull request Jul 13, 2018

[ZEPPELIN-3438] Passing Z variables to BigQuery #3068

Closed

1 task

Conversation

sanjaydasgupta commented Apr 2, 2018

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanjaydasgupta commented Apr 7, 2018

Uh oh!

felixcheung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sanjaydasgupta commented Apr 8, 2018

Uh oh!

felixcheung left a comment

Choose a reason for hiding this comment

Uh oh!

sanjaydasgupta commented Apr 9, 2018

Uh oh!

sanjaydasgupta commented Apr 11, 2018

Uh oh!

felixcheung commented Apr 11, 2018

Uh oh!

sanjaydasgupta commented Apr 11, 2018

Uh oh!

sanjaydasgupta commented Apr 16, 2018

Uh oh!

sanjaydasgupta commented Apr 22, 2018

Uh oh!

sanjaydasgupta commented Apr 22, 2018

Uh oh!

felixcheung commented Apr 23, 2018

Uh oh!

sanjaydasgupta commented Apr 27, 2018

Uh oh!

felixcheung commented Apr 28, 2018

Uh oh!

felixcheung commented Apr 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants