ZEPPELIN-3379 Refactoring of JDBC autocomplete.#2970
Closed
mebelousov wants to merge 0 commit into
Closed
Conversation
| } | ||
|
|
||
| @Override | ||
| public InterpreterResult interpret(String originalCmd, InterpreterContext contextInterpreter) { |
Contributor
There was a problem hiding this comment.
Hi @mebelousov the change proposed in these lines removes the capability described in ZEPPELIN-3377 (Passing Z variables to JDBC interpreter) and the corresponding PR-2903.
Is it necessary to remove ZEPPELIN-3377 capability to implement this PR?
Contributor
Author
There was a problem hiding this comment.
@sanjaydasgupta
I wasn't careful with git.
Reopen PR in #2972
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Current implementation of autocomplete allows only completion in
schema.table.columnscenario. Such scenario exclude tables for default schema.The PR fixes the scenario with tables in default schema and alias processing.
Also I want to add feature to complete columns for used tables in statement from blank cursor.
The autocomplete was tested for Greenplum 4.3 (PostgreSQL), Oracle 11g, MySQL (Hive Metastore) and Hive.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3379
How should this be tested?
Screenshots (if appropriate)
Questions: