Skip to content

[ZEPPELIN-550] Let interpreter define function for angular js#587

Closed
Leemoonsoo wants to merge 6 commits into
apache:masterfrom
Leemoonsoo:new_angular_api
Closed

[ZEPPELIN-550] Let interpreter define function for angular js#587
Leemoonsoo wants to merge 6 commits into
apache:masterfrom
Leemoonsoo:new_angular_api

Conversation

@Leemoonsoo
Copy link
Copy Markdown
Member

What is this PR for?

This allow interpreter define a function that callable from front-end.

What type of PR is it?

Feature

Todos

  • - implement AngularFunction
  • - add tests
  • - add docs

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-550

How should this be tested?

Check screenshot

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo Leemoonsoo force-pushed the new_angular_api branch 2 times, most recently from f304193 to b8c2719 Compare January 1, 2016 08:35
@Leemoonsoo Leemoonsoo closed this Jan 2, 2016
@corneadoug
Copy link
Copy Markdown
Contributor

@Leemoonsoo Closed?

@Leemoonsoo
Copy link
Copy Markdown
Member Author

This PR is fully functioning with test and docs. However, i think #591 provides much simpler way to use angular display system.
While this PR still adds some complexity into the code base, i'd like to not merge this code.
What do you think?

@corneadoug
Copy link
Copy Markdown
Contributor

@Leemoonsoo I think #591 is easier indeed.
Just asking in case closing it was a mistake :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants