Utilities for Angular Display system#591
Conversation
5ed4ffa to
e0ce18f
Compare
|
Please review this PR |
There was a problem hiding this comment.
shouldn't this be from the parent pom?
There was a problem hiding this comment.
Zeppelin submodule can have different scala.version dependency, especially for interpreter. While one interpreter uses scala 2.10, the other uses scala 2.11. So i think it's better not having scala.version in root pom file.
There was a problem hiding this comment.
Sure, it makes sense. Wouldn't the display module running in the Spark interpreter process and would need to match scala build to work?
There was a problem hiding this comment.
Right, If there're interpreter that uses scala 2.11 for example, then display module may add support for scala 2.11.
|
looks good, could you follow up with updating the doc http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/displaysystem/angular.html or similar? |
|
@Leemoonsoo Can you provide a screen capture/code sample to show how we can use those utilities function to update an Angular object server-side from the front-end ? My intention is to have a paragraph with %angular interpreter that "pushes" a value to the angular object repository server-side and to be re-used by another interpreter in another paragraph. Example: -------- paragraph1 --------
//Some manual Bootstrap form
Login : <input onClick="pushToBackEnd('login')">....</input> ... -------- paragraph2 -------- SELECT * FROM users WHERE login={{login}}; The pushToBackEnd() method will be responsible for that feature. Can this PR meet the feature above ? |
|
@doanduyhai The examples in this PR's description can be run on %spark interpreter. |
|
Thanks for the clarifications @Leemoonsoo. I'll try to push a small PR for the front-end angular value push |
dda24ec to
9195021
Compare
|
I've made small change after #588 merged. Usage now slightly changed, when import these utilities. When you want to work in notebook scope import org.apache.zeppelin.display.angular.notebookscope._
import AngularElem._When you want to work in paragraph scope import org.apache.zeppelin.display.angular.paragraphscope._
import AngularElem._ |
|
#650 needs to be updated too then |
|
#650 is updated. |
### What is this PR for? This PR is related #591 created by Leemoonsoo. I just added a section explaining the **Utilities for Angular Display System** to `docs/angular.md`. ### What type of PR is it? Documentation ### Todos * [x] - Add a section for explaining Utilities for Angular Display System to angular.md ### Is there a relevant Jira issue? No. But there is a related PR: #591 (and maybe #588) ### How should this be tested? Just apply this PR and checkout the `Display System -> Angular` tab in Zeppelin web site. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No. Author: Ryu Ah young <fbdkdud93@hanmail.net> Closes #650 from AhyoungRyu/display_utils_docs and squashes the following commits: 6923400 [Ryu Ah young] (Documentation): Add package import information 280b846 [Ryu Ah young] (Documentation): Fix some grammar errors in angular.md 13330d0 [Ryu Ah young] (Documentation): Fix some sentences a7cf9ac [Ryu Ah young] (Documentation): Utilities for Angular Display System
### What is this PR for? Master branch build failure after merging #655 #591 ### What type of PR is it? Hot Fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <moon@apache.org> Closes #680 from Leemoonsoo/ZEPPELIN-619_followup and squashes the following commits: beac930 [Lee moon soo] Fix test
What is this PR for?
Angular display system provides way to Interpreter interact with front-end.
However, the api was pretty much low level and not very much intuitive, it was difficult to make readable code. This PR provides simple intuitive API for using angular display system by leveraging scala.xml. Following is usage
Import
or
Display element
Event handler
Bind model
Interact with model
What type of PR is it?
Feature
Todos
Is there a relevant Jira issue?
How should this be tested?
See usage and screenshot
Screenshots (if appropriate)
Example of basic usage

Example of string converter

Questions: