Skip to content

(Documentation): Utilities for Angular Display System#650

Closed
AhyoungRyu wants to merge 4 commits into
apache:masterfrom
AhyoungRyu:display_utils_docs
Closed

(Documentation): Utilities for Angular Display System#650
AhyoungRyu wants to merge 4 commits into
apache:masterfrom
AhyoungRyu:display_utils_docs

Conversation

@AhyoungRyu
Copy link
Copy Markdown
Contributor

What is this PR for?

This PR is related #591 created by @Leemoonsoo. I just added a section explaining the Utilities for Angular Display System to docs/angular.md.

What type of PR is it?

Documentation

Todos

  • - Add a section for explaining Utilities for Angular Display System to angular.md

Is there a relevant Jira issue?

No. But there is a related PR: #591 (and maybe #588)

How should this be tested?

Just apply this PR and checkout the Display System -> Angular tab in Zeppelin web site.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

Comment thread docs/displaysystem/angular.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clicked button -> When the button is clicked
increased -> incremented

(where is numWatched defined?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numWatched value is defined in the image (<img src="/assets/themes/zeppelin/img/screenshots/display_angular2.png" width="60%" />).

@AhyoungRyu
Copy link
Copy Markdown
Contributor Author

@felixcheung
Thank you for the comments. I applied them : )

Comment thread docs/displaysystem/angular.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as an view template of
-> as a view template for

@AhyoungRyu
Copy link
Copy Markdown
Contributor Author

I should've checked more the existing documentation. Thank you for your review @corneadoug : )

@corneadoug
Copy link
Copy Markdown
Contributor

@AhyoungRyu I think we should also specify that #591 is also for scala
@Leemoonsoo I'm just checking all the infos in that doc and would love your insight:

  • AngularDisplay can be used only with scala?
  • The new syntax introduced in Utilities for Angular Display system #591 is based on paragraphScope and notebookScope, however z.angularBind is based on notebookScope and globalScope. Shouldn't they all have the same scopes?

@Leemoonsoo
Copy link
Copy Markdown
Member

AngularDisplay can be used only with scala?

Although AngularElem, AngularModel introduced in #591 is designed to be used in scala, ZeppelinDisplay module does not need to have that restriction. So it can provide API for the other language in the future.

The new syntax introduced in #591 is based on paragraphScope and notebookScope, however z.angularBind is based on notebookScope and globalScope. Shouldn't they all have the same scopes?

I'm planning to deprecate globalScope in the future while globalScope almost never get removed from notebook file and usage is quite limited.

Also z.angularBind() need to be deprecated while it's proving duplicated API after #591 merged, and i think #591 is better and easier API to use.

@doanduyhai
Copy link
Copy Markdown
Contributor

Guys, I may update also this doc for my new PR about adding the same utilities function client-side: #678

@asfgit asfgit closed this in e87f5b1 Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants