Skip to content

Merge 2.2#2003

Merged
soyuka merged 13 commits into
api-platform:masterfrom
soyuka:merge-2.2
Jun 6, 2018
Merged

Merge 2.2#2003
soyuka merged 13 commits into
api-platform:masterfrom
soyuka:merge-2.2

Conversation

@soyuka

@soyuka soyuka commented Jun 5, 2018

Copy link
Copy Markdown
Member

No description provided.

@teohhanhui

Copy link
Copy Markdown
Contributor

Let's wait for #1993

…xception-annotation

Remove expected exception annotations
@soyuka

soyuka commented Jun 5, 2018

Copy link
Copy Markdown
Member Author

let me add it :)

Comment thread tests/Annotation/ApiResourceTest.php Outdated
*/
public function testConstructWithInvalidAttribute()
{
$this->expectException(\ApiPlatform\Core\Exception\InvalidArgumentException::class);

@teohhanhui teohhanhui Jun 5, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add use statement for this.

@bendavies

Copy link
Copy Markdown
Contributor

#1993 is in!

@soyuka

soyuka commented Jun 5, 2018

Copy link
Copy Markdown
Member Author

let's wait for #2004 :D

@teohhanhui

Copy link
Copy Markdown
Contributor

#2004 is merged. 😄

@teohhanhui

Copy link
Copy Markdown
Contributor

Resolving conflicts should be done in the merge commit or further commits, without rewriting history. 😛

@soyuka soyuka merged commit 79bfe04 into api-platform:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants