Move lint jobs to CircleCI

[teohhanhui]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

[bendavies]

you can add a php-cs-fixer fixer cache step

[teohhanhui]

@bendavies Good catch! :D

[bendavies]

are you sure this is correct?
you never restore using .BuildNum so it seems pointless.
(i'm aware of how circle ci restore_cache works with substrings)

[bendavies]

i thought you might
save key:

php-cs-fixer-cache-{{ .Branch }}-{{ .Revision }}

restore keys:

keys:
  - php-cs-fixer-cache-{{ .Branch }}-{{ .Revision }}
  - php-cs-fixer-cache-{{ .Branch }}
  - php-cs-fixer-cache

[teohhanhui]

It's intentional. The .BuildNum is for cache busting.

[bendavies]

ah, in my project i actually generate a hash of all php files they php-cs-fixer runs over, then cache on that.

something like:
find src tests -type f -name "*.php" -exec md5sum {} + > php-cs-fixer.checksum

- restore_cache:
  keys:
    - php-cs-fixer-{{ checksum "php-cs-fixer.checksum" }}
    - php-cs-fixer-
...
- save_cache:
  key: php-cs-fixer-{{ checksum "php-cs-fixer.checksum" }}
  paths:
    - .php_cs.cache

then there is no need for cache busting.

[bendavies]

there is npm caching in here, but i can't see that npm is ever ran. am i missing it?

[teohhanhui]

@bendavies npx ;)

[bendavies]

ah! thanks

[teohhanhui]

Overall build time should be back down to under 10 minutes (roughly). 🎉

[Simperfit]

Thanks @teohhanhui