Removed hard dependencies on doctrine odm to run the tests by Toflar · Pull Request #2703 · api-platform/core

Toflar · 2019-04-06T17:15:51Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#2484
License	MIT
Doc PR

soyuka

Love it! Many thanks for this @Toflar it wasn't an easy task haha!

WDYT @api-platform/core-team ? IMO it'd be good to have this especially that new contributors won't have to install mongodb to run the tests!

Toflar · 2019-04-08T09:46:35Z

Finally 😄 Cleaned up, rebased and squashed. The code coverage drop is because mongodb is now its own phpunit config. But I don't understand why we're testing on both, travis and circleci anyway? 😄

teohhanhui

Minor stuff but otherwise great work! 🎉

alanpoulain · 2019-04-08T16:04:53Z

+    /**
+     * @group mongodb
+     */
+    public function testLoadDefaultConfigWithOdm()


Suggested change

public function testLoadDefaultConfigWithOdm()

public function testLoadDefaultConfigWithMongoDbOdm()

Because there are other ones.

alanpoulain · 2019-04-08T16:09:05Z

        <server name="KERNEL_DIR" value="tests/Fixtures/app/" />
        <server name="KERNEL_CLASS" value="AppKernel" />
-        <server name="APP_ENV" value="test_mongodb" />
+        <server name="APP_ENV" value="mongodb" />


Are you sure it's working as expected? Because there is a specific configuration for this environment:

https://github.com/api-platform/core/blob/master/tests/Fixtures/app/config/config_test_mongodb.yml

https://github.com/api-platform/core/blob/master/tests/Fixtures/app/config/routing_test_mongodb.yml

Well, tests are green so you tell me 😄

@Toflar But the config wouldn't get applied correctly. ~~So the APP_ENV should be reverted to test_mongodb.~~ 😄

Or better, rename the config files, since we do the same for elasticsearch.

@Toflar I think we should rename the config files instead, for consistency.

@alanpoulain Can you advise why there is config_common.yml (imported from config_orm.yml and config_services_mongodb.yml), config_orm.yml (imported from config_test.yml) and config_mongodb.yml (~~I don't see where this is imported~~ uhh, there is already a mongodb environment previously)?

Note https://github.com/api-platform/core/blob/v2.4.2/tests/Fixtures/app/AppKernel.php#L97

It's very confusing if we name config files the same way when it's not environment-specific.

Okay @Toflar, so my suggestion is that we should merge mongodb and test_mongodb environments into one mongodb environment.

Yeah that's what I was trying 😄 So I revert the latest commit again?

Yes... But we need to make sure the relevant parts of the old test_mongodb environment are merged in, e.g.:

tests/Fixtures/app/config/config_test_mongodb.yml
tests/Fixtures/app/config/config_services_mongodb.yml
tests/Fixtures/app/config/routing_test_mongodb.yml

And the old files removed.

Co-Authored-By: Toflar <yanick.witschi@terminal42.ch>

…ensionTest.php Co-Authored-By: Toflar <yanick.witschi@terminal42.ch>

This reverts commit 5780260.

Toflar · 2019-04-30T08:42:47Z

There we go. Ping @teohhanhui :) The code coverage drop is related to the fact that the mongodb testsuite is now separated so...

alanpoulain · 2019-04-30T08:53:46Z

I don't understand why you asked this modification @teohhanhui.
The test configuration was separated from the environment configuration mongodb because the PHPUnit tests don't need the same configuration as the Behat tests.
That's what is done today for the ORM part.

teohhanhui · 2019-04-30T20:49:41Z

The test configuration was separated from the environment configuration mongodb because the PHPUnit tests don't need the same configuration as the Behat tests.

Yes, I understand, but we don't need two environments when one is enough. If one environment can be reused for both, it simplifies things.

That's what is done today for the ORM part.

It's just one test environment for both phpunit and behat.

soyuka · 2019-05-03T08:12:11Z

lmao what's the status on these discussion guys? I'd like to merge this asap because it's really good for DX.

Toflar · 2019-05-03T08:18:08Z

Imho it's ready, I don't know what Teoh and Alan want me to change. We can also get this sorted on Slack maybe?

alanpoulain · 2019-05-03T09:29:40Z

I understand the POV of @teohhanhui but we need to be uniform then. Why having a config_orm.yml?
And I think the coverage should not drop. We need to launch the MongoDB tests in CircleCI and merge its coverage with the others.

teohhanhui · 2019-05-03T10:37:08Z

but we need to be uniform then. Why having a config_orm.yml?

Oh, that's a separate issue about the config file naming. I don't think we care about that in this PR. The main thing I asked for is one environment for mongodb, and as far as I could tell, that's already done.

We need to launch the MongoDB tests in CircleCI and merge its coverage with the others.

I can take care of that in another PR. We need to do the same for elasticsearch, right?

teohhanhui · 2019-05-03T13:26:20Z

Thanks @Toflar! 🎉 🚀

soyuka · 2019-05-05T09:06:58Z

❤️ 🚀

Toflar force-pushed the optional-mongodb-tests branch 2 times, most recently from dd6c1d1 to b40effc Compare April 7, 2019 08:57

antograssiot added the ⭐ EU-FOSSA Hackathon label Apr 7, 2019

soyuka approved these changes Apr 8, 2019

View reviewed changes

Toflar force-pushed the optional-mongodb-tests branch from 390bb64 to 64a17c7 Compare April 8, 2019 09:05

Removed hard dependencies on doctrine odm to run the tests

e7f7813

Toflar force-pushed the optional-mongodb-tests branch from 64a17c7 to e7f7813 Compare April 8, 2019 09:11

Toflar changed the title ~~[WIP] Removed hard dependencies on doctrine odm to run the tests~~ Removed hard dependencies on doctrine odm to run the tests Apr 8, 2019

teohhanhui suggested changes Apr 8, 2019

View reviewed changes

alanpoulain reviewed Apr 8, 2019

View reviewed changes

Comment thread tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php Outdated

alanpoulain reviewed Apr 8, 2019

View reviewed changes

Comment thread tests/Bridge/Symfony/Bundle/DependencyInjection/ConfigurationTest.php Outdated

Toflar added 2 commits April 9, 2019 10:16

Apply suggestions from code review

a5a8f9c

Co-Authored-By: Toflar <yanick.witschi@terminal42.ch>

CS

2120d58

teohhanhui mentioned this pull request Apr 9, 2019

CI: install MongoDB stuff only when needed, upgrade to PHPUnit 8 #2484

Closed

Toflar and others added 4 commits April 29, 2019 15:44

Revert renaming the environment test_mongodb to mongodb

5780260

Update tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExt…

5d0079c

…ensionTest.php Co-Authored-By: Toflar <yanick.witschi@terminal42.ch>

Revert "Revert renaming the environment test_mongodb to mongodb"

9a37710

This reverts commit 5780260.

Updated mongodb test suite configuration

8aaad92

teohhanhui approved these changes May 3, 2019

View reviewed changes

teohhanhui merged commit 09e8006 into api-platform:2.4 May 3, 2019

Toflar deleted the optional-mongodb-tests branch May 3, 2019 13:39

alanpoulain mentioned this pull request May 12, 2019

[DX] Dockerfile and docker-compose #2787

Closed

alanpoulain mentioned this pull request Jan 29, 2020

Ensure that api:openapi:export produces JSON with unescaped forward slashes #3368

Merged

	public function testLoadDefaultConfigWithOdm()
	public function testLoadDefaultConfigWithMongoDbOdm()

Uh oh!

Uh oh!

Conversation

Toflar commented Apr 6, 2019

Uh oh!

soyuka left a comment

Choose a reason for hiding this comment

Uh oh!

Toflar commented Apr 8, 2019

Uh oh!

teohhanhui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teohhanhui Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teohhanhui Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teohhanhui Apr 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teohhanhui Apr 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Toflar commented Apr 30, 2019

Uh oh!

alanpoulain commented Apr 30, 2019

Uh oh!

teohhanhui commented Apr 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soyuka commented May 3, 2019

Uh oh!

Toflar commented May 3, 2019

Uh oh!

alanpoulain commented May 3, 2019

Uh oh!

teohhanhui commented May 3, 2019

Uh oh!

teohhanhui commented May 3, 2019

Uh oh!

soyuka commented May 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

teohhanhui Apr 9, 2019 •

edited

Loading

teohhanhui Apr 9, 2019 •

edited

Loading

teohhanhui Apr 29, 2019 •

edited

Loading

teohhanhui Apr 29, 2019 •

edited

Loading

teohhanhui commented Apr 30, 2019 •

edited

Loading