Skip to content

[DX] Dockerfile and docker-compose#2787

Closed
alanpoulain wants to merge 1 commit into
api-platform:masterfrom
alanpoulain:dx-docker
Closed

[DX] Dockerfile and docker-compose#2787
alanpoulain wants to merge 1 commit into
api-platform:masterfrom
alanpoulain:dx-docker

Conversation

@alanpoulain

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

I'm using Docker for testing API Platform and I think it could be interesting to add it to API Platform to improve DX.

The image comes with MongoDB and XDebug.

It's complementary to #2703 because even if the tests are not run with MongoDB by default, if some tests related to MongoDB fail in Travis, you might need to run them locally.

WDYT?

@teohhanhui

Copy link
Copy Markdown
Contributor

I just use the Docker setup from api-platform/api-platform, and do (in the php container):

pecl install mongodb && docker-php-ext-enable mongodb

@teohhanhui

Copy link
Copy Markdown
Contributor

it could be interesting to add it to API Platform to improve DX

We should keep Dockerfiles in a separate repo if we want to have custom Docker images for running tests / builds. But there should be no docker-compose.yml.

Having them in this repo will create more confusion.

@alanpoulain

Copy link
Copy Markdown
Member Author

Having them in this repo will create more confusion.

I was thinking this too, that's why it's a proposal. I don't know, maybe if it's correctly explained it will not cause confusion.

@dunglas

dunglas commented May 15, 2019

Copy link
Copy Markdown
Member

I'm -1 too. Our skeleton and symfony/flex#128 should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants