Add a stub package for ext-mongodb#3431
Conversation
teohhanhui
commented
Mar 6, 2020
teohhanhui
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | fixes #3236, fixes #3368 (comment) |
| License | MIT |
| Doc PR | N/A |
| - checkout | ||
| - restore-mongodb-php-extension-build-cache: | ||
| php_version: << parameters.php_version >> | ||
| - install-mongodb-php-extension |
There was a problem hiding this comment.
Rationale: Let PHPStan use our stubs so that we know when it's broken (time to sync changes from https://github.com/JetBrains/phpstorm-stubs/blob/master/mongodb/mongodb.php)... 🙏
c608736 to
cf3a702
Compare
|
Awesome |
|
Do you have any concerns about these stub files being in the repository? |
| "twig/twig": "^1.42.3 || ^2.12", | ||
| "webonyx/graphql-php": ">=0.13.1 <1.0" | ||
| "webonyx/graphql-php": ">=0.13.1 <1.0", | ||
| "zz-api-platform-dev/stubs-mongodb": "@dev" |
There was a problem hiding this comment.
what's with the zz-api-platform-dev ? :p
There was a problem hiding this comment.
So that it's sorted at the end. 🤯
|
Indeed I'm not a huge fan of having this in this repository, can't we install this from a distant package via composer? |
|
I'm not sure, |
cf3a702 to
3d80a80
Compare
|
@soyuka I've extracted the stubs to https://github.com/teohhanhui/stubs-mongodb |
3d80a80 to
7817cca
Compare
|
Travis CI needed a bit of hand holding. Hopefully future jobs will be fine... Flaky jobs are annoying. |
|
Awesome job thanks @teohhanhui it'll help a lot on contributing to api-platform :D |
3 participants
