Skip to content

Add a stub package for ext-mongodb #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teohhanhui merged 1 commit into from
Mar 9, 2020
+12 −36
Merged

Add a stub package for ext-mongodb #3431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
version: 2.1

.constants:
- &ext-mongodb-version '1.6.1'

commands:
clear-test-app-cache:
steps:
Expand All @@ -19,11 +16,6 @@ commands:
- run:
name: Disable xdebug PHP extension
command: sudo rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
install-mongodb-php-extension:
steps:
- install-php-extension-from-pecl:
extension_name: mongodb
extension_version: *ext-mongodb-version
install-php-extension-from-pecl:
parameters:
extension_name:
Expand Down Expand Up @@ -64,16 +56,6 @@ commands:
- composer-{{ .Revision }}
- composer-{{ .Branch }}
- composer-
restore-mongodb-php-extension-build-cache:
parameters:
php_version:
description: PHP version (major.minor).
type: string
steps:
- restore-php-extension-build-cache:
extension_name: mongodb
extension_version: *ext-mongodb-version
php_version: << parameters.php_version >>
restore-php-cs-fixer-cache:
steps:
- restore_cache:
Expand Down Expand Up @@ -118,16 +100,6 @@ commands:
paths:
- ~/.composer/cache
key: composer-{{ .Revision }}-{{ .BuildNum }}
save-mongodb-php-extension-build-cache:
parameters:
php_version:
description: PHP version (major.minor).
type: string
steps:
- save-php-extension-build-cache:
extension_name: mongodb
extension_version: *ext-mongodb-version
php_version: << parameters.php_version >>
save-php-cs-fixer-cache:
steps:
- save_cache:
Expand Down Expand Up @@ -231,11 +203,6 @@ jobs:
working_directory: ~/api-platform/core
steps:
- checkout
- restore-mongodb-php-extension-build-cache:
php_version: << parameters.php_version >>
- install-mongodb-php-extension

@teohhanhui teohhanhui Mar 6, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rationale: Let PHPStan use our stubs so that we know when it's broken (time to sync changes from https://github.com/JetBrains/phpstorm-stubs/blob/master/mongodb/mongodb.php)... 🙏

- save-mongodb-php-extension-build-cache:
php_version: << parameters.php_version >>
- disable-xdebug-php-extension
- disable-php-memory-limit
- restore-composer-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ env:
COMPOSER_ALLOW_SUPERUSER: '1' # https://getcomposer.org/doc/03-cli.md#composer-allow-superuser
COMPOSER_INSTALLER_COMMIT: fb22b78362d31c0d2bf516d1f8cdfd2745caa431
COVERAGE: '0'
EXT_MONGODB_VERSION: '1.6.1'
EXT_MONGODB_VERSION: '1.7.3'
EXT_PCOV_VERSION: '1.0.6'

jobs:
Expand Down
4 changes: 3 additions & 1 deletion .php_cs.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ HEADER;

$finder = PhpCsFixer\Finder::create()
->in(__DIR__)
->exclude('tests/Fixtures/app/var')
->exclude([
'tests/Fixtures/app/var',
])
->append([
'tests/Fixtures/app/console',
]);
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ install:
- ps: |
$web = New-Object Net.WebClient
$web.Headers.Add('user-agent', 'AppVeyor')
$web.DownloadFile('https://windows.php.net/downloads/pecl/releases/mongodb/1.6.1/php_mongodb-1.6.1-7.4-nts-vc15-x64.zip', 'c:\tools\php74\ext\php_mongodb.zip')
$web.DownloadFile('https://windows.php.net/downloads/pecl/releases/mongodb/1.7.3/php_mongodb-1.7.3-7.4-nts-vc15-x64.zip', 'c:\tools\php74\ext\php_mongodb.zip')
- 7z x php_mongodb.zip -y >nul
- cd ..
- copy php.ini-production php.ini /Y
Expand Down
7 changes: 7 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"symfony/validator": "^3.4 || ^4.0 || ^5.0",
"symfony/web-profiler-bundle": "^4.2 || ^5.0",
"symfony/yaml": "^3.4 || ^4.0 || ^5.0",
"teohhanhui/stubs-mongodb": "@dev",
"twig/twig": "^1.42.3 || ^2.12",
"webonyx/graphql-php": ">=0.13.1 <1.0"
},
Expand Down Expand Up @@ -119,6 +120,12 @@
"ApiPlatform\\Core\\Tests\\": "tests/"
}
},
"repositories": [
{
"type": "vcs",
"url": "https://github.com/teohhanhui/stubs-mongodb"
}
],
"config": {
"preferred-install": {
"*": "dist"
Expand Down