Exceptions to status code#123
Merged
Merged
Conversation
teohhanhui
suggested changes
Oct 14, 2016
| # Enable the Nelmio Api doc integration. | ||
| enable_nelmio_api_doc: false | ||
|
|
||
| # Map exceptions to http status codes |
| # Map exceptions to http status codes | ||
| exception_to_status: | ||
| Symfony\Component\Serializer\Exception\ExceptionInterface: 400 # with a status code | ||
| ApiPlatform\Core\Exception\InvalidArgumentException: 'HTTP_BAD_REQUEST' # or with a constant defined in the 'Symfony\Component\HttpFoundation\Response' class |
Contributor
There was a problem hiding this comment.
This is a misfeature. Sorry that I didn't catch this.
Symfony 3.2 will support using PHP constants in YAML: http://symfony.com/blog/new-in-symfony-3-2-php-constants-in-yaml-files
We should remove this.
Member
Author
There was a problem hiding this comment.
https://github.com/api-platform/core/pull/797/files#diff-a01015ec3cfbd89ee246335fd528c816R114 it's done manually there
Contributor
There was a problem hiding this comment.
Yes, I mean we should remove it.
Member
There was a problem hiding this comment.
Yes I hesitated to keep this feature because of that. But no comments during the PR, so...
soyuka
force-pushed
the
doc-exceptions
branch
from
October 14, 2016 08:25
2c7fb6f to
91acc29
Compare
Member
|
Thanks @soyuka |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document api-platform/core#797 in configuration
Should this be added to another chapter too?