Skip to content

Exceptions to status code #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 1 commit into from
Oct 17, 2016
Merged

Exceptions to status code #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ api_platform:

# Enable the Nelmio Api doc integration.
enable_nelmio_api_doc: false

# Map exceptions to HTTP status codes
exception_to_status:
Symfony\Component\Serializer\Exception\ExceptionInterface: 400 # with a status code
ApiPlatform\Core\Exception\InvalidArgumentException: 'HTTP_BAD_REQUEST' # or with a constant defined in the 'Symfony\Component\HttpFoundation\Response' class

@teohhanhui teohhanhui Oct 14, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a misfeature. Sorry that I didn't catch this.

Symfony 3.2 will support using PHP constants in YAML: http://symfony.com/blog/new-in-symfony-3-2-php-constants-in-yaml-files

We should remove this.

@soyuka soyuka Oct 14, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/api-platform/core/pull/797/files#diff-a01015ec3cfbd89ee246335fd528c816R114 it's done manually there

@teohhanhui teohhanhui Oct 14, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I mean we should remove it.

@meyerbaptiste meyerbaptiste Oct 14, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I hesitated to keep this feature because of that. But no comments during the PR, so...


collection:

# The default order of results.
Expand Down