Feature/remove both lib server folders#1555
Merged
marla-singer merged 49 commits intodevelopfrom Sep 14, 2016
Merged
Conversation
…oard into feature/remove-both-lib-server-folders
Contributor
Author
|
@marla-singer thanks for the quick review. I have made small changes to 18 files, related to |
ratings/client/rating.js
Outdated
| if (Meteor.userId() === null) { | ||
| // Get translated user message | ||
| const userMessage = TAPi18n.__('api-backend-rating-anonymous'); | ||
| const message = TAPi18n.__('api-backend-rating-anonymous'); |
Contributor
There was a problem hiding this comment.
Preferably use underscore instead of dash
Contributor
Author
There was a problem hiding this comment.
This has been changed.
Contributor
Author
|
I am going to double-check our i18n hyphens. |
Contributor
Author
|
OK, I was looking at i18n strings and realized we are no longer using the |
Contributor
Contributor
Author
|
Made the requested fixes. Please review. |
Contributor
Author
|
@marla-singer I have fixed the conflicts. Please review and merge, if possible, ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #936
Closes #1556
Closes #1557
Closes #1558
Closes #1559
Closes #1575
Closes #1577
Closes #1578
Closes #1579
Changes
/bothfolder into relevant locations/libfolder into relevant locations/serverfolder into relevant locationseditApicomponentmanageApiscomponent