-
Notifications
You must be signed in to change notification settings - Fork 33
Disable proxy button when proxy is added #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e71765f
Disable "add proxy button"
frenchbread 3424314
Fix
frenchbread 24cd709
Insert rule
frenchbread 52a4002
lint
frenchbread 8945813
i18n label
frenchbread 6914c4a
Add title attr to button
frenchbread 16dbd71
info tooltip
frenchbread 51dbd54
Merge branch 'develop' into feature/add-proxy-btn-disabled
frenchbread 4174bc9
Revert "info tooltip"
frenchbread 2214905
cleaned up
NNN b21977e
Simplify code
frenchbread 759f8b4
Comments
frenchbread 0ce8df1
Merge branch 'develop' into feature/add-proxy-btn-disabled
frenchbread 70c5602
Merge branch 'develop' into feature/add-proxy-btn-disabled
frenchbread 88bad47
Cleanup
frenchbread File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,30 +2,41 @@ import { Proxies } from '../collection'; | |
| import { Template } from 'meteor/templating'; | ||
| import { ReactiveVar } from 'meteor/reactive-var'; | ||
|
|
||
| Template.proxies.onCreated(function(){ | ||
| Template.proxies.onCreated(function () { | ||
| const instance = this; | ||
|
|
||
| instance.proxies = new ReactiveVar(); | ||
| instance.isDisabled = new ReactiveVar(); | ||
|
|
||
| instance.subscribe('allProxies'); | ||
|
|
||
| instance.autorun(() => { | ||
| if (instance.subscriptionsReady()) { | ||
| // Update reactive vatiable with proxies cursor when subscription is ready | ||
| instance.proxies.set(Proxies.find()); | ||
|
|
||
| // Get proxies count | ||
| const proxiesCount = Proxies.find().count(); | ||
|
|
||
| // Set button disabled if at least one proxy is already added | ||
| instance.isDisabled.set(proxiesCount >= 1); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| Template.proxies.events({ | ||
| 'click #add-proxy': function (event, instance) { | ||
| Modal.show('addProxy', { proxy: {}, isEdit: false }); | ||
|
||
| } | ||
| }, | ||
| }); | ||
|
|
||
| Template.proxies.helpers({ | ||
| proxies () { | ||
| const instance = Template.instance(); | ||
| return instance.proxies.get(); | ||
| } | ||
| }, | ||
| isDisabled () { | ||
| const instance = Template.instance(); | ||
| return instance.isDisabled.get(); | ||
| }, | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This help text is unnecessary, if we simply hide the Add Proxy button.