Skip to content

Feature/595 userprofile enhancement#751

Closed
sebbel wants to merge 9 commits intodevelopfrom
feature/595-userprofile-enhancement
Closed

Feature/595 userprofile enhancement#751
sebbel wants to merge 9 commits intodevelopfrom
feature/595-userprofile-enhancement

Conversation

@sebbel
Copy link
Copy Markdown
Contributor

@sebbel sebbel commented Jan 5, 2016

This PR is still WIP.

There are a few minor bugs as stated in #595.

  • If chosing an already existant username, the usernameExists function is overridden and a "Mongo db duplicate key error" is shown to the user.
  • Removed the rules in Meteor.user.allow in order to make it work for now. Will re-implement the rules when I know what's going on.

SBe and others added 9 commits December 22, 2015 10:20
Added sAlert to the condition if profile name is not set.
- Redesigned the quickform on profile.html
- Hooks for updateProfile Form to check the username for availability
- Entered a if statement, to show a sAlert incase username is missing
- Redirecting to /profile if username is missing
- Implementing a method on server/methods/accounts to check for already taken
usernames
@sebbel sebbel added the WIP label Jan 5, 2016
@sebbel
Copy link
Copy Markdown
Contributor Author

sebbel commented Jan 6, 2016

I would like to remove this Pullrequest in favor of #752

@brylie
Copy link
Copy Markdown
Contributor

brylie commented Jan 7, 2016

OK.

@brylie brylie closed this Jan 7, 2016
@brylie brylie removed the in progress label Jan 7, 2016
@brylie
Copy link
Copy Markdown
Contributor

brylie commented Jan 7, 2016

@sebbel delete the feature branch, if it is not relevant to your other pull request.

@sebbel
Copy link
Copy Markdown
Contributor Author

sebbel commented Jan 7, 2016

Okay, will delete it now
On Thu, Jan 07, 2016 at 04:41:02AM -0800, Brylie Christopher Oxley wrote:

@sebbel delete the feature branch, if it is not relevant to your other pull request.


Reply to this email directly or view it on GitHub:
https://github.com/apinf/api-umbrella-dashboard/pull/751#issuecomment-169653202

@sebbel sebbel deleted the feature/595-userprofile-enhancement branch January 7, 2016 12:44
@brylie brylie restored the feature/595-userprofile-enhancement branch January 8, 2016 13:40
@sebbel sebbel deleted the feature/595-userprofile-enhancement branch January 15, 2016 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants