Feature/595b-Ensuring that users have a username, closes #752

[sebbel]

• Added a Field to Signup and Login to supply a username
• The username is a required field
• Cannot choose a username that already exists
• User can login with username or email

[sebbel]

@apinf/developers please review

[sebbel]

Just tested on a local instance, the Profile Template is using the Meteor.user.username field.
Now just thinking how I could wire a sAlert in there. I am thinking of defining it on the profile.js file to just check for absence of Meteor.user.username

[brylie]

@sebbel I have encountered a bug, and am not sure the work-to around. When registering via Github, with a Github account that has the same username (e.g. sebbel) as an existing Apinf account (e.g. sebbel), I get the error: "username already exists".

In the case of the Github registration, we somehow need to get the username after the Github registration/user creation happens.

[brylie]

It also might be possible to allow users to log in without a username. Then, the Github login could complete, and the user would be prompted to create a username.

[sebbel]

Thanks for your feedback. I haven't tested the GitHub authentication but
there might be a way to let github users pass registration with an empty
username. the redirect would take place in that case.

Am Donnerstag, 7. Januar 2016 schrieb Brylie Christopher Oxley :

It also might be possible to allow users to log in without a username.
Then, the Github login could complete, and the user would be prompted to
create a username.

—
Reply to this email directly or view it on GitHub
https://github.com/apinf/api-umbrella-dashboard/pull/752#issuecomment-169660028
.

[brylie]

Good idea. Lets try that out.

[jykae]

@sebbel @brylie I am taking a look at this one.

[jykae]

@apinf/developers please review

[brylie]

@bajiat , @jykae and I worked on this last week, so it might be good for another of the @apinf/developers to review this PR.

[jykae]

Line 7 in profile.js: "return sAlert.error(error);" is causing "Uncaught TypeError: Converting circular structure to JSON". Trying to find out how to fix it.

[jykae]

I fixed what I could, please review.

[brylie]

@elnzv please review 🔜

[55]

When setting an username at /profile if it exists, no error message is showing.

[brylie]

OK, we have to figure out some way to send a simple message back to AutoForm saying the username exists. That MongoDB error will not suffice, and the error will ideally appear directly below the username field.

The AutoForm onError callback was removed, but may be the right place for a fix here.

[bajiat]

Pass the following error to the user: "User name already exists. Enter another user name."

[sebbel]

Please review @apinf/developers
@elnzv or @brylie I would be happy if you could connect the new /both/collections/_messages file to the translations file. I have added a comment in the _messages file and already the entry for the i8en but I am unsure why the translation is not working on my end.

[brylie]

@sebbel thanks! 👍 This is perfect.

[brylie]

I opened a support request about translating custom validation texts:
Meteor-Community-Packages/meteor-simple-schema#534

[brylie]

We can merge this PR, as full translation capabilities are not required for PoC.

[brylie]

OK, I moved the i18n folder into lib, so that it would load before other code. This enables us to use i18n strings in validation messages. Cheers!

[brylie]

I have also merged changes from develop to resolve conflicts.

[brylie]

@apinf/developers please review once more, and merge if possible.