Add poseidon fixes to sp1-new-tmp branch#7
Merged
Conversation
Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com>
Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com>
Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com>
Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com>
Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com>
arthurpaulino
previously approved these changes
Jun 18, 2024
Member
arthurpaulino
left a comment
arthurpaulino
left a comment
There was a problem hiding this comment.
I recognize these commit messages from the PR that ultimately made Lair work (#5), so I'm good with these changes
Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com>
adr1anh
previously approved these changes
Jun 18, 2024
wwared
suggested changes
Jun 18, 2024
There was a problem hiding this comment.
Blocking until Sphinx compiles with these changes - specifically the From bounds on matmul_internal. Talking with @mpenciak over whether this can be changed only on plonky3 (keeping the API the same) or if it requires a corresponding sphinx PR/patch
wwared
approved these changes
Jun 18, 2024
wwared
added a commit
that referenced
this pull request
Jun 20, 2024
* Allow more generic Poseidon2 width Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Arbitrary width for matrix.rs Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `supported_width` constant and comment Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `matmul_exterior` Air friendly Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * re-add `condition` method to `FilteredAirBuilder` * Acknowledge clippy * Acknowledge cargo fmt * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Acknowledge cargo fmt * fix: Attempt to remove From bound from matmul_internal * acknowledge cargo fmt --------- Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: wwared <wwared@users.noreply.github.com>
huitseeker
pushed a commit
that referenced
this pull request
Aug 3, 2024
* Allow more generic Poseidon2 width Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Arbitrary width for matrix.rs Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `supported_width` constant and comment Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `matmul_exterior` Air friendly Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * re-add `condition` method to `FilteredAirBuilder` * Acknowledge clippy * Acknowledge cargo fmt * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Acknowledge cargo fmt * fix: Attempt to remove From bound from matmul_internal * acknowledge cargo fmt --------- Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: wwared <wwared@users.noreply.github.com>
huitseeker
pushed a commit
that referenced
this pull request
Aug 11, 2024
* Allow more generic Poseidon2 width Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Arbitrary width for matrix.rs Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `supported_width` constant and comment Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `matmul_exterior` Air friendly Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * re-add `condition` method to `FilteredAirBuilder` * Acknowledge clippy * Acknowledge cargo fmt * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Acknowledge cargo fmt * fix: Attempt to remove From bound from matmul_internal * acknowledge cargo fmt --------- Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: wwared <wwared@users.noreply.github.com>
huitseeker
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Allow more generic Poseidon2 width Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Arbitrary width for matrix.rs Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `supported_width` constant and comment Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `matmul_exterior` Air friendly Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * re-add `condition` method to `FilteredAirBuilder` * Acknowledge clippy * Acknowledge cargo fmt * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Acknowledge cargo fmt * fix: Attempt to remove From bound from matmul_internal * acknowledge cargo fmt --------- Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: wwared <wwared@users.noreply.github.com>
huitseeker
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Allow more generic Poseidon2 width Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Arbitrary width for matrix.rs Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `supported_width` constant and comment Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `matmul_exterior` Air friendly Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * re-add `condition` method to `FilteredAirBuilder` * Acknowledge clippy * Acknowledge cargo fmt * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Acknowledge cargo fmt * fix: Attempt to remove From bound from matmul_internal * acknowledge cargo fmt --------- Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: wwared <wwared@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the commits from
ah/poseidon-arbitrary-widthto the top of thesp1-new-tmpbranch.