chore: Update sp1-new#8
Closed
wwared wants to merge 2 commits into
Closed
Conversation
* Allow more generic Poseidon2 width Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Arbitrary width for matrix.rs Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `supported_width` constant and comment Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Make `matmul_exterior` Air friendly Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * re-add `condition` method to `FilteredAirBuilder` * Acknowledge clippy * Acknowledge cargo fmt * Remove `PrimeField` bounds Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> * Acknowledge cargo fmt * fix: Attempt to remove From bound from matmul_internal * acknowledge cargo fmt --------- Signed-off-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com> Co-authored-by: wwared <wwared@users.noreply.github.com>
Member
samuelburnham
left a comment
samuelburnham
left a comment
There was a problem hiding this comment.
Reviewing on behalf of CI only: approved once this gets a positive check-downstream-compiles signal by rebasing on top of #6 post-merge
Author
|
Superseded by #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
sp1-newto include3b5265f9d5af36534a46caebf0617595cfb42c5aas well as the changes from #7Necessary pre-requisite for argumentcomputer/sphinx#61
This PR has no new commits that weren't already in
sp1-new-tmp