Skip to content

Transitive dependency support for check-lurk-compiles #13

@huitseeker

Description

@huitseeker

As of #11 we're grepping for the name of the dependency in the lurk Cargo.toml, which will work if :

  • we're testing that lurk compiles with a modified DEPENDENCY,
  • and DEPENDENCY is a direct dependency of lurk (that is, it's specified in the Lurk cargo.toml).

The resulting patch will apply transitively.

However, it would be perfectly OK to patch a dependency that's used only transitively, by setting the dependency name to a specific string, and overriding it with a patch. No need for that dependency to be in the Cargo.toml.
This will work because patches will apply transitively.

That will become useful if we want to check-lurk-compiles on a non-direct dependency of lurk.

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions