Generalize check-lurk-compiles.yml#61
Merged
Merged
Conversation
samuelburnham
force-pushed
the
check-downstream-compiles
branch
6 times, most recently
from
498ca6a to
bd8a21e
Compare
samuelburnham
changed the title
check-lurk-compiles.yml
Contributor
|
This needs a rebase! |
samuelburnham
force-pushed
the
check-downstream-compiles
branch
from
bd8a21e to
f542a2e
Compare
huitseeker
previously approved these changes
Mar 23, 2024
Contributor
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
This looks really nice, though at some point I wonder if we shouldn't move to https://crates.io/crates/cargo-edit.
Thanks a lot!
samuelburnham
force-pushed
the
check-downstream-compiles
branch
10 times, most recently
from
9602485 to
192ec2f
Compare
samuelburnham
force-pushed
the
check-downstream-compiles
branch
from
56ec70e to
0760948
Compare
huitseeker
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-lurk-compiles.ymlto work with arbitrary downstream crates that import the workflow callerCargo.tomlof the downstream crateTODO:
crates.iopatch supportSuccessful runs:
samuelburnham/workspace-test#1
Closes #13
Note
Requires a careful merge as the branch is load-bearing in some caller repositories