feat: Support multiple crates in check-downstream-compiles#68
Merged
Conversation
wwared
approved these changes
Jun 20, 2024
wwared
left a comment
There was a problem hiding this comment.
This looks good, I just want to remind about this comment because we keep adding more inscrutable sed lines to this workflow.
But it makes sense and it seems to work, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optionally takes in the
more-pathsinput, which will take the same Cargo.toml path patches for the initially patched crate and apply them to each specified crate further down the stack.For example, argumentcomputer/Plonky3#6 shows:
patches.txtpatches.txtto eachCargo.tomlfile in the repo.Note
This PR should be merged before argumentcomputer/Plonky3#6, as the latter currently depends on the
downstream-transitivebranch here.